From: Ronnie Sahlberg <lsahlber@redhat.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] Add new xattr test 532
Date: Wed, 6 Mar 2019 21:46:23 -0500 (EST) [thread overview]
Message-ID: <22121819.6359026.1551926783232.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190306125234.GJ2824@desktop>
----- Original Message -----
> From: "Eryu Guan" <guaneryu@gmail.com>
> To: "Ronnie Sahlberg" <lsahlber@redhat.com>
> Cc: "fstests" <fstests@vger.kernel.org>
> Sent: Wednesday, 6 March, 2019 10:52:34 PM
> Subject: Re: [PATCH] Add new xattr test 532
>
> On Tue, Mar 05, 2019 at 02:36:13PM +1000, Ronnie Sahlberg wrote:
> > This test is cloned from 097 but has had all the tests for trusted.*
> > removed.
> > This makes it possible to use this test on filesystems that can only
> > provide user.* xattrs such as CIFS.
> >
> > Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
>
> Sorry I missed your last patch of this clone..
No worries. I will resend it later once I address Daves concerns.
>
> Do I need to do special setup for CIFS to support xattr? Currently I got
> test _notrun because attrs are not supported by CIFS. I was mounting a
> local samba server with
>
> -o vers=3.0 -o username=user,password=passwd,sfu -o
> context=system_u:object_r:root_t:s0 //localhost/scratch /mnt/scratch
You don't need the 'sfu' mount option but you likely need to make sure you have the proper vfs modules loaded for samba:
I use this on my share :
[Share]
path = /Share
read only = no
guest ok = no
vfs objects = acl_xattr, streams_xattr aio_pthread
ea support = yes
aio read size = 16384
aio write size = 16384
I think the only important one is ea support = yes (the xattrs are stored as EAs)
>
> Kernel is 5.0.0-rc7.
>
> But instead of cloning all the user.* xattr tests, I think it's better
> to split generic/097, leave all trusted.* xattr tests there and move all
> user.* xattr tests to this new test. So we don't have to maintain two
> copys of the same user.* xattr tests.
>
> Thanks,
> Eryu
>
next prev parent reply other threads:[~2019-03-07 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 4:36 [PATCH] Add new xattr test 532 Ronnie Sahlberg
2019-03-06 12:52 ` Eryu Guan
2019-03-07 2:46 ` Ronnie Sahlberg [this message]
2019-03-08 2:42 ` Eryu Guan
2019-03-08 3:01 ` ronnie sahlberg
2019-03-08 3:09 ` Eryu Guan
-- strict thread matches above, loose matches on Subject: below --
2019-03-05 4:38 Ronnie Sahlberg
2019-03-06 21:55 ` Dave Chinner
2019-03-07 4:08 Ronnie Sahlberg
2019-03-08 3:34 Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22121819.6359026.1551926783232.JavaMail.zimbra@redhat.com \
--to=lsahlber@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox