* [PATCH] xfs/065: make sure SCRATCH_DEV is unmount before mkfs
@ 2019-03-27 7:45 Zorro Lang
2019-03-27 14:41 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Zorro Lang @ 2019-03-27 7:45 UTC (permalink / raw)
To: fstests
Commit "8309b39a fstests: fix broken _require_scratch usage" did
below change on xfs/065:
-_scratch_unmount 2>/dev/null
+_scratch_mkfs_xfs >> $seqres.full
It cause xfs/065 always fails now, as:
QA output created by 065
mkfs.xfs: /dev/sdb2 contains a mounted filesystem
...
So use _require_scratch, to make sure the SCRATCH_DEV is unmounted
before mkfs.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
tests/xfs/065 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/xfs/065 b/tests/xfs/065
index c0d1ee93..f09bd947 100755
--- a/tests/xfs/065
+++ b/tests/xfs/065
@@ -50,6 +50,7 @@ _list_dir()
# real QA test starts here
_supported_fs xfs
_supported_os Linux
+_require_scratch
#
# too much hassle to get output matching with quotas turned on
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs/065: make sure SCRATCH_DEV is unmount before mkfs
2019-03-27 7:45 [PATCH] xfs/065: make sure SCRATCH_DEV is unmount before mkfs Zorro Lang
@ 2019-03-27 14:41 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-03-27 14:41 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Wed, Mar 27, 2019 at 03:45:09PM +0800, Zorro Lang wrote:
> Commit "8309b39a fstests: fix broken _require_scratch usage" did
> below change on xfs/065:
>
> -_scratch_unmount 2>/dev/null
> +_scratch_mkfs_xfs >> $seqres.full
>
> It cause xfs/065 always fails now, as:
> QA output created by 065
> mkfs.xfs: /dev/sdb2 contains a mounted filesystem
> ...
>
> So use _require_scratch, to make sure the SCRATCH_DEV is unmounted
> before mkfs.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
DOH, stupid editor... <grumble>
Sorry about that.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/065 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/065 b/tests/xfs/065
> index c0d1ee93..f09bd947 100755
> --- a/tests/xfs/065
> +++ b/tests/xfs/065
> @@ -50,6 +50,7 @@ _list_dir()
> # real QA test starts here
> _supported_fs xfs
> _supported_os Linux
> +_require_scratch
>
> #
> # too much hassle to get output matching with quotas turned on
> --
> 2.17.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-27 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-27 7:45 [PATCH] xfs/065: make sure SCRATCH_DEV is unmount before mkfs Zorro Lang
2019-03-27 14:41 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox