From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Dave Chinner <david@fromorbit.com>,
Olga Kornievskaia <olga.kornievskaia@gmail.com>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH v4 1/3] common/rc: check support for xfs_io copy_range -f N
Date: Mon, 15 Jul 2019 15:55:14 +0300 [thread overview]
Message-ID: <20190715125516.7367-2-amir73il@gmail.com> (raw)
In-Reply-To: <20190715125516.7367-1-amir73il@gmail.com>
Implement "_require_xfs_io_command copy_range -f" to check for
the option added by following xfsprogs commit:
xfs_io: allow passing an open file to copy_range
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
common/rc | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 000a7cc8..f1cec5ad 100644
--- a/common/rc
+++ b/common/rc
@@ -2105,9 +2105,16 @@ _require_xfs_io_command()
;;
"copy_range")
local testcopy=$TEST_DIR/$$.copy.xfs_io
+ local copy_opts=$testfile
+ if [ "$param" == "-f" ]; then
+ # source file is the open destination file
+ testcopy=$testfile
+ copy_opts="0 -d 4k"
+ fi
$XFS_IO_PROG -F -f -c "pwrite 0 4k" $testfile > /dev/null 2>&1
- testio=`$XFS_IO_PROG -F -f -c "copy_range $testfile" $testcopy 2>&1`
+ testio=`$XFS_IO_PROG -F -f -c "copy_range $param $copy_opts" $testcopy 2>&1`
rm -f $testcopy > /dev/null 2>&1
+ param_checked="$param"
;;
"falloc" )
testio=`$XFS_IO_PROG -F -f -c "falloc $param 0 1m" $testfile 2>&1`
--
2.17.1
next prev parent reply other threads:[~2019-07-15 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 12:55 [PATCH v4 0/3] fstests: copy_file_range() tests Amir Goldstein
2019-07-15 12:55 ` Amir Goldstein [this message]
2019-07-15 12:55 ` [PATCH v4 2/3] generic: copy_file_range bounds test Amir Goldstein
2019-07-21 16:43 ` Eryu Guan
2019-07-15 12:55 ` [PATCH v4 3/3] generic: cross-device copy_file_range test Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715125516.7367-2-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=olga.kornievskaia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox