From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Baihua Lu <lubaihua0331@gmail.com>
Cc: fstests@vger.kernel.org, balu@microsoft.com
Subject: Re: [PATCH] common/rc: fix _require_xfs_io_command utimes check
Date: Wed, 30 Oct 2019 20:41:06 -0700 [thread overview]
Message-ID: <20191031034106.GC15224@magnolia> (raw)
In-Reply-To: <20191031012553.72731-1-lubaihua0331@gmail.com>
On Thu, Oct 31, 2019 at 01:25:53AM +0000, Baihua Lu wrote:
> There is an error on checking utimes command. Put quotation mark after four "0".
>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index a2a28f32..657d05d3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2186,7 +2186,7 @@ _require_xfs_io_command()
> _notrun "xfs_io $command support is missing"
> ;;
> "utimes" )
> - testio=`$XFS_IO_PROG -f -c "utimes" 0 0 0 0 $testfile 2>&1`
> + testio=`$XFS_IO_PROG -f -c "utimes 0 0 0 0" $testfile 2>&1`
> ;;
> "syncfs")
> touch $testfile
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-31 3:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 1:25 [PATCH] common/rc: fix _require_xfs_io_command utimes check Baihua Lu
2019-10-31 3:41 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-28 7:56 Baihua Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031034106.GC15224@magnolia \
--to=darrick.wong@oracle.com \
--cc=balu@microsoft.com \
--cc=fstests@vger.kernel.org \
--cc=lubaihua0331@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox