* [PATCH] common/rc: fix _require_xfs_io_command utimes check
@ 2019-10-31 1:25 Baihua Lu
2019-10-31 3:41 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Baihua Lu @ 2019-10-31 1:25 UTC (permalink / raw)
To: fstests; +Cc: balu, Baihua Lu
There is an error on checking utimes command. Put quotation mark after four "0".
Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index a2a28f32..657d05d3 100644
--- a/common/rc
+++ b/common/rc
@@ -2186,7 +2186,7 @@ _require_xfs_io_command()
_notrun "xfs_io $command support is missing"
;;
"utimes" )
- testio=`$XFS_IO_PROG -f -c "utimes" 0 0 0 0 $testfile 2>&1`
+ testio=`$XFS_IO_PROG -f -c "utimes 0 0 0 0" $testfile 2>&1`
;;
"syncfs")
touch $testfile
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] common/rc: fix _require_xfs_io_command utimes check
2019-10-31 1:25 [PATCH] common/rc: fix _require_xfs_io_command utimes check Baihua Lu
@ 2019-10-31 3:41 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2019-10-31 3:41 UTC (permalink / raw)
To: Baihua Lu; +Cc: fstests, balu
On Thu, Oct 31, 2019 at 01:25:53AM +0000, Baihua Lu wrote:
> There is an error on checking utimes command. Put quotation mark after four "0".
>
> Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
Looks ok to me,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index a2a28f32..657d05d3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2186,7 +2186,7 @@ _require_xfs_io_command()
> _notrun "xfs_io $command support is missing"
> ;;
> "utimes" )
> - testio=`$XFS_IO_PROG -f -c "utimes" 0 0 0 0 $testfile 2>&1`
> + testio=`$XFS_IO_PROG -f -c "utimes 0 0 0 0" $testfile 2>&1`
> ;;
> "syncfs")
> touch $testfile
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] common/rc: fix _require_xfs_io_command utimes check
@ 2019-10-28 7:56 Baihua Lu
0 siblings, 0 replies; 3+ messages in thread
From: Baihua Lu @ 2019-10-28 7:56 UTC (permalink / raw)
To: fstests; +Cc: balu, decui, Lili.Deng, weh, Baihua Lu
There is an error on checking utimes command. Put quotation mark after four "0".
Signed-off-by: Baihua Lu <lubaihua0331@gmail.com>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index a29bd780..aeac903b 100644
--- a/common/rc
+++ b/common/rc
@@ -2184,7 +2184,7 @@ _require_xfs_io_command()
_notrun "xfs_io $command support is missing"
;;
"utimes" )
- testio=`$XFS_IO_PROG -f -c "utimes" 0 0 0 0 $testfile 2>&1`
+ testio=`$XFS_IO_PROG -f -c "utimes 0 0 0 0" $testfile 2>&1`
;;
"syncfs")
touch $testfile
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-31 3:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-31 1:25 [PATCH] common/rc: fix _require_xfs_io_command utimes check Baihua Lu
2019-10-31 3:41 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2019-10-28 7:56 Baihua Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox