From: Jeffle Xu <jefflexu@linux.alibaba.com>
To: fstests@vger.kernel.org
Cc: joseph.qi@linux.alibaba.com, Jeffle Xu <jefflexu@linux.alibaba.com>
Subject: [PATCH] common/dmthin: modify DMTHIN_POOL_NAME
Date: Fri, 12 Jun 2020 13:18:20 +0800 [thread overview]
Message-ID: <20200612051820.80814-2-jefflexu@linux.alibaba.com> (raw)
_dmthin_set_queue() gets $cluster_size by 'dmsetup table | grep
$DMTHIN_POOL_NAME'. The original name 'thin-pool' is accidently
the same as the fourth field of the output of 'dmsetup table'.
For example,
vg-pool-tpool: 0 64864256 thin-pool 252:0 252:1 128 0 0
Thus if there is other thin-pool in the test environment, except
for the thin-pool created by _dmthin_init(), the parsed $cluster_size
may be a multi-line string, which is unexpected.
This issue caused a failure of generic/347 and generic/500, while the
dmesg reports 'Invalid argument count'.
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
common/dmthin | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/dmthin b/common/dmthin
index 61dd6f89..c58c3948 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -15,7 +15,7 @@ DMTHIN_DATA_DEV="/dev/mapper/$DMTHIN_DATA_NAME"
DMTHIN_META_NAME="thin-meta"
DMTHIN_META_DEV="/dev/mapper/$DMTHIN_META_NAME"
# Backing pool dev (combination of above)
-DMTHIN_POOL_NAME="thin-pool"
+DMTHIN_POOL_NAME="thin-provision-pool"
DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME"
# Thin volume
DMTHIN_VOL_NAME="thin-vol"
--
2.27.0
reply other threads:[~2020-06-12 5:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612051820.80814-2-jefflexu@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=joseph.qi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox