public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] common/dmthin: modify DMTHIN_POOL_NAME
@ 2020-06-12  5:18 Jeffle Xu
  0 siblings, 0 replies; only message in thread
From: Jeffle Xu @ 2020-06-12  5:18 UTC (permalink / raw)
  To: fstests; +Cc: joseph.qi, Jeffle Xu

_dmthin_set_queue() gets $cluster_size by 'dmsetup table | grep
$DMTHIN_POOL_NAME'. The original name 'thin-pool' is accidently
the same as the fourth field of the output of 'dmsetup table'.

For example,
vg-pool-tpool: 0 64864256 thin-pool 252:0 252:1 128 0 0

Thus if there is other thin-pool in the test environment, except
for the thin-pool created by _dmthin_init(), the parsed $cluster_size
may be a multi-line string, which is unexpected.

This issue caused a failure of generic/347 and generic/500, while the
dmesg reports 'Invalid argument count'.

Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
 common/dmthin | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/dmthin b/common/dmthin
index 61dd6f89..c58c3948 100644
--- a/common/dmthin
+++ b/common/dmthin
@@ -15,7 +15,7 @@ DMTHIN_DATA_DEV="/dev/mapper/$DMTHIN_DATA_NAME"
 DMTHIN_META_NAME="thin-meta"
 DMTHIN_META_DEV="/dev/mapper/$DMTHIN_META_NAME"
 # Backing pool dev (combination of above)
-DMTHIN_POOL_NAME="thin-pool"
+DMTHIN_POOL_NAME="thin-provision-pool"
 DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME"
 # Thin volume
 DMTHIN_VOL_NAME="thin-vol"
-- 
2.27.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-12  5:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-12  5:18 [PATCH] common/dmthin: modify DMTHIN_POOL_NAME Jeffle Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox