From: Christoph Hellwig <hch@infradead.org>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org, darrick.wong@oracle.com,
david@fromorbit.com, ira.weiny@intel.com,
linux-xfs@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file
Date: Mon, 14 Sep 2020 08:26:11 +0100 [thread overview]
Message-ID: <20200914072611.GB29046@infradead.org> (raw)
In-Reply-To: <20200914051400.32057-1-yangx.jy@cn.fujitsu.com>
On Mon, Sep 14, 2020 at 01:13:59PM +0800, Xiao Yang wrote:
> 'tPnE' flags are only valid for a directory so check them on a directory.
>
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
The change looks good, but I wonder if we should split the chattr
tests into
_require_chattr_file_flag
and
_require_chattr_dir_flag
to make the whole thing a little less convoluted..
next prev parent reply other threads:[~2020-09-14 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 5:13 [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file Xiao Yang
2020-09-14 5:14 ` [PATCH v2 2/2] common/rc: Add extra check for xfs_io -c "chattr" on XFS Xiao Yang
2020-09-14 7:26 ` Christoph Hellwig [this message]
2020-09-17 4:05 ` [PATCH v2 1/2] common/rc: Check 'tPnE' flags on a directory instead of a regilar file Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914072611.GB29046@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=ira.weiny@intel.com \
--cc=linux-xfs@vger.kernel.org \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox