* [PATCH] Fix generic/127 to exit if any subtest fails
@ 2020-10-19 12:58 Matthew Wilcox
2020-10-19 16:04 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2020-10-19 12:58 UTC (permalink / raw)
To: fstests
If one of the subtests of generic/127 fails, we proceed with the rest of
the tests, potentially overwriting useful data. This makes it stop as
soon as any of the subtests fails.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
diff --git a/tests/generic/127 b/tests/generic/127
index dedd8bbf..d4b2cc38 100755
--- a/tests/generic/127
+++ b/tests/generic/127
@@ -90,16 +90,16 @@ _supported_fs generic
_supported_os Linux
_require_test
-_fsx_lite_nommap
-_fsx_lite_mmap
+_fsx_lite_nommap || exit
+_fsx_lite_mmap || exit
-_fsx_std_nommap
-_fsx_std_mmap
+_fsx_std_nommap || exit
+_fsx_std_mmap || exit
#flush cache after write
FSX_ARGS="-f $FSX_ARGS"
-_fsx_std_nommap
-_fsx_std_mmap
+_fsx_std_nommap || exit
+_fsx_std_mmap || exit
status=0
_cleanup
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix generic/127 to exit if any subtest fails
2020-10-19 12:58 [PATCH] Fix generic/127 to exit if any subtest fails Matthew Wilcox
@ 2020-10-19 16:04 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2020-10-19 16:04 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: fstests
On Mon, Oct 19, 2020 at 01:58:39PM +0100, Matthew Wilcox wrote:
>
> If one of the subtests of generic/127 fails, we proceed with the rest of
> the tests, potentially overwriting useful data. This makes it stop as
> soon as any of the subtests fails.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Yayyyyyyy
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
>
> diff --git a/tests/generic/127 b/tests/generic/127
> index dedd8bbf..d4b2cc38 100755
> --- a/tests/generic/127
> +++ b/tests/generic/127
> @@ -90,16 +90,16 @@ _supported_fs generic
> _supported_os Linux
> _require_test
>
> -_fsx_lite_nommap
> -_fsx_lite_mmap
> +_fsx_lite_nommap || exit
> +_fsx_lite_mmap || exit
>
> -_fsx_std_nommap
> -_fsx_std_mmap
> +_fsx_std_nommap || exit
> +_fsx_std_mmap || exit
>
> #flush cache after write
> FSX_ARGS="-f $FSX_ARGS"
> -_fsx_std_nommap
> -_fsx_std_mmap
> +_fsx_std_nommap || exit
> +_fsx_std_mmap || exit
>
> status=0
> _cleanup
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-19 12:58 [PATCH] Fix generic/127 to exit if any subtest fails Matthew Wilcox
2020-10-19 16:04 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox