From: Palmer Dabbelt <palmerdabbelt@google.com>
To: fstests@vger.kernel.org
Cc: Palmer Dabbelt <palmerdabbelt@google.com>
Subject: [PATCH] open_by_handle: Don't use MAX_HANDLE_SZ
Date: Wed, 28 Oct 2020 21:03:39 -0700 [thread overview]
Message-ID: <20201029040338.238990-1-palmerdabbelt@google.com> (raw)
When I compile this normally I end up with the definition of
MAX_HANDLE_SZ, but when I compile it in a minimal buildroot-based
environment I don't. I'm not sure where this is supposed to come from,
but as of 3f4760c2 ("open_by_handle: add option -z to query file handle
size") it appears to be unnecessary.
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
I haven't actually run this, as I haven't figured out how to yet. It
does build, though.
---
src/open_by_handle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/open_by_handle.c b/src/open_by_handle.c
index 0f74ed08..ddeffb7a 100644
--- a/src/open_by_handle.c
+++ b/src/open_by_handle.c
@@ -92,7 +92,6 @@ Examples:
struct handle {
struct file_handle fh;
- unsigned char fid[MAX_HANDLE_SZ];
} handle[MAXFILES], dir_handle;
void usage(void)
--
2.29.1.341.ge80a0c044ae-goog
next reply other threads:[~2020-10-29 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 4:03 Palmer Dabbelt [this message]
2020-10-29 9:56 ` [PATCH] open_by_handle: Don't use MAX_HANDLE_SZ Amir Goldstein
2020-11-09 22:45 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029040338.238990-1-palmerdabbelt@google.com \
--to=palmerdabbelt@google.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox