From: Dave Chinner <david@fromorbit.com>
To: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] open_by_handle: Don't use MAX_HANDLE_SZ
Date: Tue, 10 Nov 2020 09:45:37 +1100 [thread overview]
Message-ID: <20201109224537.GA2256367@dread.disaster.area> (raw)
In-Reply-To: <20201029040338.238990-1-palmerdabbelt@google.com>
On Wed, Oct 28, 2020 at 09:03:39PM -0700, Palmer Dabbelt wrote:
> When I compile this normally I end up with the definition of
> MAX_HANDLE_SZ, but when I compile it in a minimal buildroot-based
> environment I don't. I'm not sure where this is supposed to come from,
> but as of 3f4760c2 ("open_by_handle: add option -z to query file handle
> size") it appears to be unnecessary.
Hmmm - it should be trivial to find where it comes from with grep:
$ grep -R MAX_HANDLE_SZ /usr/include
/usr/include/x86_64-linux-gnu/bits/fcntl-linux.h:# define MAX_HANDLE_SZ 128
$
IOWs, MAX_HANDLE_SZ is defined via:
#include <fcntl.h>
which src/open_by_handle.c already includes.
IOWs, this looks like a problem with your build root environment not
defining MAX_HANDLE_SZ correctly, not a problem with fstests.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2020-11-09 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 4:03 [PATCH] open_by_handle: Don't use MAX_HANDLE_SZ Palmer Dabbelt
2020-10-29 9:56 ` Amir Goldstein
2020-11-09 22:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109224537.GA2256367@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=palmerdabbelt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox