public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] src/swapon.c: initiate p to NULL
@ 2021-02-01  7:57 Sun Ke
  0 siblings, 0 replies; only message in thread
From: Sun Ke @ 2021-02-01  7:57 UTC (permalink / raw)
  To: fstests; +Cc: zlang, sunke32

when run make, show:
swapon.c:135:3: warning: 'p' may be used uninitialized in this function
[-Wmaybe-uninitialized]
   memcpy(p, buf, BUF_SIZE);
      ^~~~~~~~~~~~~~~~~~~~~~~~

This's a fake uninitialized warning.
gcc think the 'p' can be used uninitialized at here when verb is
TEST_MWRITE_BEFORE_AND_MWRITE_AFTER:
    case TEST_MWRITE_BEFORE_AND_MWRITE_AFTER:
	memcpy(p, buf, BUF_SIZE);
	break;

But, if verb is TEST_MWRITE_BEFORE_AND_MWRITE_AFTER, the 'p' will be
initialized by:
    switch (verb) {
    case TEST_MWRITE_BEFORE_AND_MWRITE_AFTER:
    case TEST_MWRITE_BEFORE:
	p = mmap(NULL, BUF_SIZE, PROT_WRITE | PROT_READ, MAP_SHARED,

Shall we make the build warning disappear?

Signed-off-by: Sun Ke <sunke32@huawei.com>
---
V2: Improve the commit message.
---
 src/swapon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/swapon.c b/src/swapon.c
index afaed405..fe8949a3 100644
--- a/src/swapon.c
+++ b/src/swapon.c
@@ -41,7 +41,7 @@ int main(int argc, char **argv)
 		.sa_handler	= handle_signal,
 	};
 	enum verbs verb = TEST_SWAPON;
-	void *p;
+	void *p = NULL;
 	ssize_t sz;
 	int fd = -1;
 	int ret, c;
-- 
2.13.6


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-01  7:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-01  7:57 [PATCH v2] src/swapon.c: initiate p to NULL Sun Ke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox