FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] src/chprojid_fail.c: Fix undefined compile error on old kernel
Date: Thu, 18 Mar 2021 09:22:45 -0700	[thread overview]
Message-ID: <20210318162245.GA1670408@magnolia> (raw)
In-Reply-To: <1615975873-19206-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

On Wed, Mar 17, 2021 at 06:11:13PM +0800, Yang Xu wrote:
> On old kernel, linux/fs.h doesn't include FS_IOC_FSGETXATTR and FS_IOC_FSGETXATTR
> ioctl flag. It also doesn't include fsxattr struct. To fix this error, just
> use global.h like fsstress.c.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>

Looks good to me, I already had a bug report this morning about this. :/

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  src/chprojid_fail.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/chprojid_fail.c b/src/chprojid_fail.c
> index 8c5b5fee..6d1e0fac 100644
> --- a/src/chprojid_fail.c
> +++ b/src/chprojid_fail.c
> @@ -15,6 +15,7 @@
>  #include <string.h>
>  #include <errno.h>
>  #include <linux/fs.h>
> +#include "global.h"
>  
>  static char zerobuf[65536];
>  
> -- 
> 2.23.0
> 

      reply	other threads:[~2021-03-18 16:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 10:11 [PATCH] src/chprojid_fail.c: Fix undefined compile error on old kernel Yang Xu
2021-03-18 16:22 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210318162245.GA1670408@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=xuyang2018.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox