* [PATCH] src/chprojid_fail.c: Fix undefined compile error on old kernel
@ 2021-03-17 10:11 Yang Xu
2021-03-18 16:22 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Yang Xu @ 2021-03-17 10:11 UTC (permalink / raw)
To: fstests; +Cc: Yang Xu
On old kernel, linux/fs.h doesn't include FS_IOC_FSGETXATTR and FS_IOC_FSGETXATTR
ioctl flag. It also doesn't include fsxattr struct. To fix this error, just
use global.h like fsstress.c.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
src/chprojid_fail.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/chprojid_fail.c b/src/chprojid_fail.c
index 8c5b5fee..6d1e0fac 100644
--- a/src/chprojid_fail.c
+++ b/src/chprojid_fail.c
@@ -15,6 +15,7 @@
#include <string.h>
#include <errno.h>
#include <linux/fs.h>
+#include "global.h"
static char zerobuf[65536];
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] src/chprojid_fail.c: Fix undefined compile error on old kernel
2021-03-17 10:11 [PATCH] src/chprojid_fail.c: Fix undefined compile error on old kernel Yang Xu
@ 2021-03-18 16:22 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2021-03-18 16:22 UTC (permalink / raw)
To: Yang Xu; +Cc: fstests
On Wed, Mar 17, 2021 at 06:11:13PM +0800, Yang Xu wrote:
> On old kernel, linux/fs.h doesn't include FS_IOC_FSGETXATTR and FS_IOC_FSGETXATTR
> ioctl flag. It also doesn't include fsxattr struct. To fix this error, just
> use global.h like fsstress.c.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Looks good to me, I already had a bug report this morning about this. :/
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> src/chprojid_fail.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/chprojid_fail.c b/src/chprojid_fail.c
> index 8c5b5fee..6d1e0fac 100644
> --- a/src/chprojid_fail.c
> +++ b/src/chprojid_fail.c
> @@ -15,6 +15,7 @@
> #include <string.h>
> #include <errno.h>
> #include <linux/fs.h>
> +#include "global.h"
>
> static char zerobuf[65536];
>
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-18 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 10:11 [PATCH] src/chprojid_fail.c: Fix undefined compile error on old kernel Yang Xu
2021-03-18 16:22 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox