From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH 2/2] generic/475: skip test when using an external log device
Date: Mon, 5 Jul 2021 00:03:07 -0400 [thread overview]
Message-ID: <20210705040307.3322709-3-tytso@mit.edu> (raw)
In-Reply-To: <20210705040307.3322709-1-tytso@mit.edu>
This test tests log recovery by kicking off fstress on the scratch fs,
then switch out the underlying the device with dm-error to see what
happens when the disk goes down. But when there is an external log
device writes to the log device still succeed, while writes to the
rest of the file system fail, and this leads to file system
corruption. So skip this test when there is an external log.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
tests/generic/475 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/generic/475 b/tests/generic/475
index 62894491..4f230430 100755
--- a/tests/generic/475
+++ b/tests/generic/475
@@ -34,6 +34,10 @@ _require_scratch
_require_dm_target error
_require_command "$KILLALL_PROG" "killall"
+if test "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ; then
+ _notrun "Cannot have external log device"
+fi
+
echo "Silence is golden."
_scratch_mkfs >> $seqres.full 2>&1
--
2.31.0
next prev parent reply other threads:[~2021-07-05 4:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 4:03 [PATCH 0/2] skip tests that don't work with an external log Theodore Ts'o
2021-07-05 4:03 ` [PATCH 1/2] dmflakey: don't run dmflakey tests with an external log device Theodore Ts'o
2021-07-05 4:03 ` Theodore Ts'o [this message]
2021-07-06 17:48 ` [PATCH 0/2] skip tests that don't work with an external log Darrick J. Wong
2021-07-18 12:54 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210705040307.3322709-3-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox