From: "Darrick J. Wong" <djwong@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 0/2] skip tests that don't work with an external log
Date: Tue, 6 Jul 2021 10:48:37 -0700 [thread overview]
Message-ID: <20210706174837.GA11571@locust> (raw)
In-Reply-To: <20210705040307.3322709-1-tytso@mit.edu>
On Mon, Jul 05, 2021 at 12:03:05AM -0400, Theodore Ts'o wrote:
> I recently tried running xfstests with an external log device, and
> found a number of failures caused by the fact that we use dmflakey and
> dmerror to take down a disk to simulate a power failure or a complete
> hard disk failure. But with an external log device, the tests don't
> correctly simulate these scenarios, so skip them.
Counter-proposal: If I sent out my series to fix all that[1], would you
review them?
--D
[1] https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=dmerror-on-rt-devices
>
> With these patches, testing with ext4 using an external log is passing
> almost all of the auto group tests, with the exception of ext4/028
> (which appears to be a genuine ext4 fsmap bug not handling external
> log devices correctly).
>
> Theodore Ts'o (2):
> dmflakey: don't run dmflakey tests with an external log device
> generic/475: skip test when using an external log device
>
> common/dmflakey | 4 ++++
> tests/generic/475 | 4 ++++
> 2 files changed, 8 insertions(+)
>
> --
> 2.31.0
>
next prev parent reply other threads:[~2021-07-06 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 4:03 [PATCH 0/2] skip tests that don't work with an external log Theodore Ts'o
2021-07-05 4:03 ` [PATCH 1/2] dmflakey: don't run dmflakey tests with an external log device Theodore Ts'o
2021-07-05 4:03 ` [PATCH 2/2] generic/475: skip test when using " Theodore Ts'o
2021-07-06 17:48 ` Darrick J. Wong [this message]
2021-07-18 12:54 ` [PATCH 0/2] skip tests that don't work with an external log Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706174837.GA11571@locust \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox