public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: fstests@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH] generic/70: Use scratch device instead of test.
Date: Thu, 19 Aug 2021 16:13:55 +0300	[thread overview]
Message-ID: <20210819131355.304528-1-nborisov@suse.com> (raw)

At the end of the test the fsstress work dir is deleted, this suggests
the test really requires a scratch device and not a test device. Change
it accordingly.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/generic/070 | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tests/generic/070 b/tests/generic/070
index 678344fa011d..c98f445ae4b8 100755
--- a/tests/generic/070
+++ b/tests/generic/070
@@ -13,7 +13,6 @@ _begin_fstest attr udf auto quick stress
 _cleanup()
 {
     cd /
-    rm -rf $TEST_DIR/fsstress
     rm -f $tmp.*
 }
 
@@ -24,11 +23,14 @@ _cleanup()
 # real QA test starts here
 _supported_fs generic
 
-_require_test
+_require_scratch
 _require_attrs
 
+_scratch_mkfs >/dev/null 2>&1
+_scratch_mount
+
 FSSTRESS_ARGS=`_scale_fsstress_args \
-	-d $TEST_DIR/fsstress \
+	-d $SCRATCH_MNT \
 	-f allocsp=0 \
 	-f freesp=0 \
 	-f bulkstat=0 \
@@ -40,5 +42,7 @@ FSSTRESS_ARGS=`_scale_fsstress_args \
         -p 1 -n 10000 -S c`
 $FSSTRESS_PROG $FSSTRESS_ARGS >$seqres.full 2>&1
 
+_scratch_unmount
+
 status=$?
 exit
-- 
2.17.1


             reply	other threads:[~2021-08-19 13:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 13:13 Nikolay Borisov [this message]
2021-08-19 15:00 ` [PATCH] generic/70: Use scratch device instead of test Zorro Lang
2021-08-19 14:56   ` Nikolay Borisov
2021-08-19 19:46     ` Theodore Ts'o
2021-08-21 22:58     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210819131355.304528-1-nborisov@suse.com \
    --to=nborisov@suse.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox