From: "Darrick J. Wong" <djwong@kernel.org>
To: Zhu Yifei <yifeix.zhu@intel.com>
Cc: fstests <fstests@vger.kernel.org>, Philip Li <philip.li@intel.com>
Subject: Re: [PATCH v1 xfstests-dev] common/populate: remove wrong check
Date: Fri, 3 Dec 2021 09:07:57 -0800 [thread overview]
Message-ID: <20211203170757.GA8442@magnolia> (raw)
In-Reply-To: <20211203095441.56318-1-yifeix.zhu@intel.com>
On Fri, Dec 03, 2021 at 05:54:41PM +0800, Zhu Yifei wrote:
> used btree_dir to check dformat, this was a wrong operation
Huh? The __populate_check_xfs_dformat you propose removing checks that
the btree-format directory that we just created actually has a data fork
in BTREE format.
The change is incorrect, NAK.
--D
> Signed-off-by: Zhu Yifei <yifeix.zhu@intel.com>
> ---
> common/populate | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/populate b/common/populate
> index 867776cd..8ad561b4 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -605,7 +605,6 @@ _scratch_xfs_populate_check() {
> __populate_check_xfs_dir "${leafn_dir}" "leafn"
> __populate_check_xfs_dir "${node_dir}" "node"
> __populate_check_xfs_dir "${btree_dir}" "btree"
> - __populate_check_xfs_dformat "${btree_dir}" "btree"
> __populate_check_xfs_dformat "${bdev}" "dev"
> __populate_check_xfs_dformat "${cdev}" "dev"
> __populate_check_xfs_dformat "${fifo}" "dev"
> --
> 2.20.1
>
prev parent reply other threads:[~2021-12-03 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 9:54 [PATCH v1 xfstests-dev] common/populate: remove wrong check Zhu Yifei
2021-12-03 17:07 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203170757.GA8442@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=philip.li@intel.com \
--cc=yifeix.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox