* [PATCH v1 xfstests-dev] common/populate: remove wrong check
@ 2021-12-03 9:54 Zhu Yifei
2021-12-03 17:07 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Zhu Yifei @ 2021-12-03 9:54 UTC (permalink / raw)
To: fstests, Philip Li; +Cc: Zhu Yifei
used btree_dir to check dformat, this was a wrong operation
Signed-off-by: Zhu Yifei <yifeix.zhu@intel.com>
---
common/populate | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/populate b/common/populate
index 867776cd..8ad561b4 100644
--- a/common/populate
+++ b/common/populate
@@ -605,7 +605,6 @@ _scratch_xfs_populate_check() {
__populate_check_xfs_dir "${leafn_dir}" "leafn"
__populate_check_xfs_dir "${node_dir}" "node"
__populate_check_xfs_dir "${btree_dir}" "btree"
- __populate_check_xfs_dformat "${btree_dir}" "btree"
__populate_check_xfs_dformat "${bdev}" "dev"
__populate_check_xfs_dformat "${cdev}" "dev"
__populate_check_xfs_dformat "${fifo}" "dev"
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 xfstests-dev] common/populate: remove wrong check
2021-12-03 9:54 [PATCH v1 xfstests-dev] common/populate: remove wrong check Zhu Yifei
@ 2021-12-03 17:07 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2021-12-03 17:07 UTC (permalink / raw)
To: Zhu Yifei; +Cc: fstests, Philip Li
On Fri, Dec 03, 2021 at 05:54:41PM +0800, Zhu Yifei wrote:
> used btree_dir to check dformat, this was a wrong operation
Huh? The __populate_check_xfs_dformat you propose removing checks that
the btree-format directory that we just created actually has a data fork
in BTREE format.
The change is incorrect, NAK.
--D
> Signed-off-by: Zhu Yifei <yifeix.zhu@intel.com>
> ---
> common/populate | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/common/populate b/common/populate
> index 867776cd..8ad561b4 100644
> --- a/common/populate
> +++ b/common/populate
> @@ -605,7 +605,6 @@ _scratch_xfs_populate_check() {
> __populate_check_xfs_dir "${leafn_dir}" "leafn"
> __populate_check_xfs_dir "${node_dir}" "node"
> __populate_check_xfs_dir "${btree_dir}" "btree"
> - __populate_check_xfs_dformat "${btree_dir}" "btree"
> __populate_check_xfs_dformat "${bdev}" "dev"
> __populate_check_xfs_dformat "${cdev}" "dev"
> __populate_check_xfs_dformat "${fifo}" "dev"
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-03 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 9:54 [PATCH v1 xfstests-dev] common/populate: remove wrong check Zhu Yifei
2021-12-03 17:07 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox