From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH] generic/019: kill background processes on interrupt
Date: Mon, 11 Apr 2022 15:48:33 +1000 [thread overview]
Message-ID: <20220411054833.2157779-1-david@fromorbit.com> (raw)
From: Dave Chinner <dchinner@redhat.com>
If you ctrl-c generic/019, it leaves fsstress processes running.
Kill them in the cleanup function so that they don't have to be
manually killed after interrupting the test.
While touching the _cleanup() function, make it do everything that
the generic _cleanup function it overrides does and fix the
indenting.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
tests/generic/019 | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/generic/019 b/tests/generic/019
index db56dac1..cda107f4 100755
--- a/tests/generic/019
+++ b/tests/generic/019
@@ -53,8 +53,10 @@ stop_fail_scratch_dev()
# Override the default cleanup function.
_cleanup()
{
- disallow_fail_make_request
- rm -f $tmp.*
+ kill $fs_pid $fio_pid &> /dev/null
+ disallow_fail_make_request
+ cd /
+ rm -r -f $tmp.*
}
RUN_TIME=$((20+10*$TIME_FACTOR))
--
2.35.1
next reply other threads:[~2022-04-11 5:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 5:48 Dave Chinner [this message]
2022-04-12 12:59 ` [PATCH] generic/019: kill background processes on interrupt David Disseldorp
2022-04-12 14:25 ` Zorro Lang
2022-04-13 0:26 ` Dave Chinner
2022-04-13 7:13 ` Amir Goldstein
2022-04-13 23:27 ` Darrick J. Wong
2022-04-18 0:02 ` Dave Chinner
2022-04-14 16:25 ` Zorro Lang
2022-04-14 19:16 ` Zorro Lang
2022-04-16 9:20 ` Amir Goldstein
2022-04-16 14:11 ` Zorro Lang
2022-04-16 17:13 ` Amir Goldstein
2022-04-18 17:07 ` Darrick J. Wong
2022-04-18 18:08 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411054833.2157779-1-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox