From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: dchinner@redhat.com
Subject: [PATCH v2 0/3]: generic/020: fix MAX_ATTRVAL_SIZE values
Date: Tue, 12 Apr 2022 12:49:58 +0200 [thread overview]
Message-ID: <20220412105001.14325-1-ddiss@suse.de> (raw)
MAX_ATTRVAL_SIZE provides a per-filesystem maximum xattr value length
limit. There are a few problems with the current values:
- XFS, UDF and Btrfs are incorrectly hardcoded to use 64 bytes
+ This is a regression from the larger value used prior to fff4359d
+ Btrfs's should be calculated using nodesize and xattr name length
- NFS currently uses a 64K limit
+ This may be above the server's underlying failsystem limit, so use
a conservative estimate instead
Cheers, David
common/attr | 175 ++++++++++++++++++++++++------------------
tests/generic/020 | 10 ++-
tests/generic/020.out | 2 +-
3 files changed, 108 insertions(+), 79 deletions(-)
next reply other threads:[~2022-04-12 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 10:49 David Disseldorp [this message]
2022-04-12 10:49 ` [PATCH v2 1/3] common/attr: add and use _attr_get_max() David Disseldorp
2022-04-13 0:31 ` Dave Chinner
2022-04-12 10:50 ` [PATCH v2 2/3] common/attr: fix MAX_ATTRVAL_SIZE for XFS, UDF, Btrfs and NFS David Disseldorp
2022-04-12 10:50 ` [PATCH v2 3/3] generic/020: fix unaligned MAX_ATTRVAL_SIZE output filter David Disseldorp
2022-04-13 0:32 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412105001.14325-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=dchinner@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox