From: Dave Chinner <david@fromorbit.com>
To: David Disseldorp <ddiss@suse.de>
Cc: fstests@vger.kernel.org, dchinner@redhat.com
Subject: Re: [PATCH v2 3/3] generic/020: fix unaligned MAX_ATTRVAL_SIZE output filter
Date: Wed, 13 Apr 2022 10:32:19 +1000 [thread overview]
Message-ID: <20220413003219.GN1609613@dread.disaster.area> (raw)
In-Reply-To: <20220412105001.14325-4-ddiss@suse.de>
On Tue, Apr 12, 2022 at 12:50:01PM +0200, David Disseldorp wrote:
> The current attr -g "$max_attrval_name" output filter is broken if
> MAX_ATTRVAL_SIZE isn't 16-byte aligned, due to od's duplicate
> suppression behaviour.
> Fix it by having od only dump one byte per line.
>
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
> tests/generic/020 | 2 +-
> tests/generic/020.out | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-04-13 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 10:49 [PATCH v2 0/3]: generic/020: fix MAX_ATTRVAL_SIZE values David Disseldorp
2022-04-12 10:49 ` [PATCH v2 1/3] common/attr: add and use _attr_get_max() David Disseldorp
2022-04-13 0:31 ` Dave Chinner
2022-04-12 10:50 ` [PATCH v2 2/3] common/attr: fix MAX_ATTRVAL_SIZE for XFS, UDF, Btrfs and NFS David Disseldorp
2022-04-12 10:50 ` [PATCH v2 3/3] generic/020: fix unaligned MAX_ATTRVAL_SIZE output filter David Disseldorp
2022-04-13 0:32 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413003219.GN1609613@dread.disaster.area \
--to=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox