From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH 3/3] xfs/348: golden output is not correct
Date: Mon, 16 May 2022 16:08:07 +1000 [thread overview]
Message-ID: <20220516060807.1295102-4-david@fromorbit.com> (raw)
In-Reply-To: <20220516060807.1295102-1-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
The output of xfs/348 encodes the observed behaviour at the time the
test was written, not the correct behaviour that should occur.
Recent improvements in verification checking in the upstream kernel
(1eb70f54c445 "xfs: validate inode fork size against fork format")
have resulted in the kernel having correct behaviour and now the
test fails. Fix the test output to reflect correct behaviour.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
tests/xfs/348.out | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/xfs/348.out b/tests/xfs/348.out
index 0d407718..9130f42a 100644
--- a/tests/xfs/348.out
+++ b/tests/xfs/348.out
@@ -108,7 +108,7 @@ would have junked entry "DATA" in directory PARENT_INO
would have junked entry "EMPTY" in directory PARENT_INO
would have junked entry "FIFO" in directory PARENT_INO
stat: 'SCRATCH_MNT/test/DIR' is a directory
-stat: 'SCRATCH_MNT/test/DATA' is a directory
+stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/SYMLINK': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning
@@ -240,7 +240,7 @@ would have junked entry "DIR" in directory PARENT_INO
would have junked entry "EMPTY" in directory PARENT_INO
would have junked entry "FIFO" in directory PARENT_INO
stat: cannot statx 'SCRATCH_MNT/test/DIR': Structure needs cleaning
-stat: 'SCRATCH_MNT/test/DATA' is a symbolic link
+stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning
stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
stat: 'SCRATCH_MNT/test/SYMLINK' is a symbolic link
stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning
--
2.35.1
next prev parent reply other threads:[~2022-05-16 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 6:08 [PATCH 0/3] fstests: test updates for XFS 5.19 kernel mods Dave Chinner
2022-05-16 6:08 ` [PATCH 1/3] fstests: filter quota warnings Dave Chinner
2022-05-16 15:26 ` Darrick J. Wong
2022-05-16 21:09 ` Dave Chinner
2022-05-16 21:09 ` Darrick J. Wong
2022-05-16 6:08 ` [PATCH 2/3] xfs/122: add attribute log formats to test output Dave Chinner
2022-05-16 15:27 ` Darrick J. Wong
2022-05-16 6:08 ` Dave Chinner [this message]
2022-05-16 15:29 ` [PATCH 3/3] xfs/348: golden output is not correct Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516060807.1295102-4-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox