public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: fstests@vger.kernel.org
Subject: [PATCH 5/8] xfs/538: fix fsstress scaling
Date: Thu,  2 Jun 2022 10:31:23 +1000	[thread overview]
Message-ID: <20220602003126.2903779-6-david@fromorbit.com> (raw)
In-Reply-To: <20220602003126.2903779-1-david@fromorbit.com>

From: Dave Chinner <dchinner@redhat.com>

_scale_fsstress_args() does time/load scaling of parameters. Doing
it also in the test causes exponential scaling instead of linear
scaling as the time/load parameters are meant to do.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/xfs/538     | 36 +++++++++++++++++-------------------
 tests/xfs/538.out |  3 +--
 2 files changed, 18 insertions(+), 21 deletions(-)

diff --git a/tests/xfs/538 b/tests/xfs/538
index e0102f48..2b5e97e5 100755
--- a/tests/xfs/538
+++ b/tests/xfs/538
@@ -47,25 +47,23 @@ done
 echo "Inject bmap_alloc_minlen_extent error tag"
 _scratch_inject_error bmap_alloc_minlen_extent 1
 
-echo "Scale fsstress args"
-args=$(_scale_fsstress_args -p $((LOAD_FACTOR * 75)) -n $((TIME_FACTOR * 1000)))
-
-echo "Execute fsstress in background"
-$FSSTRESS_PROG -d $SCRATCH_MNT $args \
-		 -f bulkstat=0 \
-		 -f bulkstat1=0 \
-		 -f fiemap=0 \
-		 -f getattr=0 \
-		 -f getdents=0 \
-		 -f getfattr=0 \
-		 -f listfattr=0 \
-		 -f mread=0 \
-		 -f read=0 \
-		 -f readlink=0 \
-		 -f readv=0 \
-		 -f stat=0 \
-		 -f aread=0 \
-		 -f dread=0 > /dev/null 2>&1
+echo "Execute fsstress"
+$FSSTRESS_PROG -d $SCRATCH_MNT \
+		$(_scale_fsstress_args -p 75 -n 1000) \
+		-f bulkstat=0 \
+		-f bulkstat1=0 \
+		-f fiemap=0 \
+		-f getattr=0 \
+		-f getdents=0 \
+		-f getfattr=0 \
+		-f listfattr=0 \
+		-f mread=0 \
+		-f read=0 \
+		-f readlink=0 \
+		-f readv=0 \
+		-f stat=0 \
+		-f aread=0 \
+		-f dread=0 > /dev/null 2>&1
 
 # success, all done
 status=0
diff --git a/tests/xfs/538.out b/tests/xfs/538.out
index 85932c82..97ebc314 100644
--- a/tests/xfs/538.out
+++ b/tests/xfs/538.out
@@ -3,5 +3,4 @@ Format and mount fs
 Consume free space
 Create fragmented filesystem
 Inject bmap_alloc_minlen_extent error tag
-Scale fsstress args
-Execute fsstress in background
+Execute fsstress
-- 
2.35.1


  parent reply	other threads:[~2022-06-02  0:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02  0:31 fstests: new tests and various fixes Dave Chinner
2022-06-02  0:31 ` [PATCH 1/8] xfstests: Add Log Attribute Replay test Dave Chinner
2022-06-02  1:05   ` Darrick J. Wong
2022-06-03  1:41   ` [PATCH 1/8 v2] fstests: " Dave Chinner
2022-06-03  2:43     ` Darrick J. Wong
2022-06-03  4:55       ` Zorro Lang
2022-06-03  5:29         ` Dave Chinner
2022-06-02  0:31 ` [PATCH 2/8] README: document _begin_fstests better Dave Chinner
2022-06-02  0:51   ` Darrick J. Wong
2022-06-02  0:31 ` [PATCH 3/8] generic/081: don't run on DAX capable devices Dave Chinner
2022-06-02  2:03   ` Darrick J. Wong
2022-06-02  0:31 ` [PATCH 4/8] generic/038: kill background threads on interrupt Dave Chinner
2022-06-02  0:51   ` Darrick J. Wong
2022-06-02  0:31 ` Dave Chinner [this message]
2022-06-02  0:52   ` [PATCH 5/8] xfs/538: fix fsstress scaling Darrick J. Wong
2022-06-02  0:31 ` [PATCH 6/8] xfs/070: filter the bad sb magic number error Dave Chinner
2022-06-02  0:52   ` Darrick J. Wong
2022-06-02  0:31 ` [PATCH 7/8] xfs/167: adjust runtime with TIME_FACTOR Dave Chinner
2022-06-02  0:53   ` Darrick J. Wong
2022-06-02  0:31 ` [PATCH 8/8] xfs/189: systemd monitoring of /etc/fstab sucks Dave Chinner
2022-06-02  1:04   ` Darrick J. Wong
2022-06-03  1:54   ` [PATCH 8/8 v2] " Dave Chinner
2022-06-03  2:41     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602003126.2903779-6-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox