Re: [PATCH 4/9] xfs: test xfs_copy doesn't do cached read before libxfs_mount

[Dave Chinner <david@fromorbit.com>]

On Tue, Jun 28, 2022 at 01:21:40PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This is a regression test for an xfs_copy fix that ensures that it
> doesn't perform a cached read of an XFS filesystem prior to initializing
> libxfs, since the xfs_mount (and hence the buffer cache) isn't set up
> yet.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  tests/xfs/844     |   33 +++++++++++++++++++++++++++++++++
>  tests/xfs/844.out |    3 +++
>  2 files changed, 36 insertions(+)
>  create mode 100755 tests/xfs/844
>  create mode 100644 tests/xfs/844.out
> 
> 
> diff --git a/tests/xfs/844 b/tests/xfs/844
> new file mode 100755
> index 00000000..688abe33
> --- /dev/null
> +++ b/tests/xfs/844
> @@ -0,0 +1,33 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2022 Oracle.  All Rights Reserved.
> +#
> +# FS QA Test 844
> +#
> +# Regression test for xfsprogs commit:
> +#
> +# XXXXXXXX ("xfs_copy: don't use cached buffer reads until after libxfs_mount")
> +#

This needs more of an explanation of why empty files are being
copied here, because it's not obvious why we'd run xfs_copy on
them...

> +. ./common/preamble
> +_begin_fstest auto copy

Wouldn't this also be quick?

Otherwise looks fine.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com