From: Dave Chinner <david@fromorbit.com>
To: Liu Yiding <liuyd.fnst@fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] generic/688: Skip test if fs doesn't support security
Date: Wed, 3 Aug 2022 08:05:37 +1000 [thread overview]
Message-ID: <20220802220537.GC3861211@dread.disaster.area> (raw)
In-Reply-To: <1659426760-2-1-git-send-email-liuyd.fnst@fujitsu.com>
On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote:
> This test require security attr. Skip test if fs doesn't support
> security attr. E.g. virtiofs
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
> ---
> tests/generic/688 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/688 b/tests/generic/688
> index 426286b6..d11b4c21 100755
> --- a/tests/generic/688
> +++ b/tests/generic/688
> @@ -7,6 +7,7 @@
> # Functional test for dropping capability bits as part of an fallocate.
> #
> . ./common/preamble
> +. ./common/attr
> _begin_fstest auto prealloc quick
Includes don't belong in the test preamble/setup section. They
belong a few lines below in the section titled:
# Include common functions.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-08-02 22:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 7:52 [PATCH] generic/688: Skip test if fs doesn't support security Liu Yiding
2022-08-02 9:17 ` Zorro Lang
2022-08-03 6:48 ` liuyd.fnst
2022-08-03 10:40 ` Zorro Lang
2022-08-04 1:32 ` liuyd.fnst
2022-08-02 22:05 ` Dave Chinner [this message]
2022-08-03 6:45 ` liuyd.fnst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802220537.GC3861211@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=liuyd.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox