Re: [PATCH] generic/688: Skip test if fs doesn't support security

["liuyd.fnst@fujitsu.com" <liuyd.fnst@fujitsu.com>]

Hi Dave.

On 8/3/22 06:05, Dave Chinner wrote:
> On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote:
>> This test require security attr. Skip test if fs doesn't support
>> security attr. E.g. virtiofs
>>
>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
>> ---
>>   tests/generic/688 | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/generic/688 b/tests/generic/688
>> index 426286b6..d11b4c21 100755
>> --- a/tests/generic/688
>> +++ b/tests/generic/688
>> @@ -7,6 +7,7 @@
>>   # Functional test for dropping capability bits as part of an fallocate.
>>   #
>>   . ./common/preamble
>> +. ./common/attr
>>   _begin_fstest auto prealloc quick
> 
> Includes don't belong in the test preamble/setup section. They
> belong a few lines below in the section titled:

Thank you for your point. :)

> 
> # Include common functions.
> 
> Cheers,
> 
> Dave.
>