* [PATCH] generic/688: Skip test if fs doesn't support security @ 2022-08-02 7:52 Liu Yiding 2022-08-02 9:17 ` Zorro Lang 2022-08-02 22:05 ` Dave Chinner 0 siblings, 2 replies; 7+ messages in thread From: Liu Yiding @ 2022-08-02 7:52 UTC (permalink / raw) To: fstests; +Cc: liuyd.fnst This test require security attr. Skip test if fs doesn't support security attr. E.g. virtiofs Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> --- tests/generic/688 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/generic/688 b/tests/generic/688 index 426286b6..d11b4c21 100755 --- a/tests/generic/688 +++ b/tests/generic/688 @@ -7,6 +7,7 @@ # Functional test for dropping capability bits as part of an fallocate. # . ./common/preamble +. ./common/attr _begin_fstest auto prealloc quick # Override the default cleanup function. @@ -28,6 +29,7 @@ _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_xfs_io_command falloc _require_test +_require_attrs security _require_congruent_file_oplen $TEST_DIR 65536 junk_dir=$TEST_DIR/$seq -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] generic/688: Skip test if fs doesn't support security 2022-08-02 7:52 [PATCH] generic/688: Skip test if fs doesn't support security Liu Yiding @ 2022-08-02 9:17 ` Zorro Lang 2022-08-03 6:48 ` liuyd.fnst 2022-08-02 22:05 ` Dave Chinner 1 sibling, 1 reply; 7+ messages in thread From: Zorro Lang @ 2022-08-02 9:17 UTC (permalink / raw) To: Liu Yiding; +Cc: fstests, djwong On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: > This test require security attr. Skip test if fs doesn't support > security attr. E.g. virtiofs > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > --- Hmm... looks like we can re-start this discussion long time ago: https://lore.kernel.org/fstests/20220323023845.saj5en74km7aibdx@zlang-mailbox/ About how can we deal with those fs doesn't support capabilities, e.g. nfs, virtiofs?? Thanks, Zorro > tests/generic/688 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/generic/688 b/tests/generic/688 > index 426286b6..d11b4c21 100755 > --- a/tests/generic/688 > +++ b/tests/generic/688 > @@ -7,6 +7,7 @@ > # Functional test for dropping capability bits as part of an fallocate. > # > . ./common/preamble > +. ./common/attr > _begin_fstest auto prealloc quick > > # Override the default cleanup function. > @@ -28,6 +29,7 @@ _require_command "$GETCAP_PROG" getcap > _require_command "$SETCAP_PROG" setcap > _require_xfs_io_command falloc > _require_test > +_require_attrs security > _require_congruent_file_oplen $TEST_DIR 65536 > > junk_dir=$TEST_DIR/$seq > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] generic/688: Skip test if fs doesn't support security 2022-08-02 9:17 ` Zorro Lang @ 2022-08-03 6:48 ` liuyd.fnst 2022-08-03 10:40 ` Zorro Lang 0 siblings, 1 reply; 7+ messages in thread From: liuyd.fnst @ 2022-08-03 6:48 UTC (permalink / raw) To: Zorro Lang; +Cc: fstests@vger.kernel.org, djwong@kernel.org Hi Zorro On 8/2/22 17:17, Zorro Lang wrote: > On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: >> This test require security attr. Skip test if fs doesn't support >> security attr. E.g. virtiofs >> >> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> >> --- > > Hmm... looks like we can re-start this discussion long time ago: > > https://lore.kernel.org/fstests/20220323023845.saj5en74km7aibdx@zlang-mailbox/ > > About how can we deal with those fs doesn't support capabilities, e.g. nfs, virtiofs?? Ahh, so I don't need to send a v2 patch until you finish above discussion. > > Thanks, > Zorro > >> tests/generic/688 | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/generic/688 b/tests/generic/688 >> index 426286b6..d11b4c21 100755 >> --- a/tests/generic/688 >> +++ b/tests/generic/688 >> @@ -7,6 +7,7 @@ >> # Functional test for dropping capability bits as part of an fallocate. >> # >> . ./common/preamble >> +. ./common/attr >> _begin_fstest auto prealloc quick >> >> # Override the default cleanup function. >> @@ -28,6 +29,7 @@ _require_command "$GETCAP_PROG" getcap >> _require_command "$SETCAP_PROG" setcap >> _require_xfs_io_command falloc >> _require_test >> +_require_attrs security >> _require_congruent_file_oplen $TEST_DIR 65536 >> >> junk_dir=$TEST_DIR/$seq >> -- >> 2.34.1 >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] generic/688: Skip test if fs doesn't support security 2022-08-03 6:48 ` liuyd.fnst @ 2022-08-03 10:40 ` Zorro Lang 2022-08-04 1:32 ` liuyd.fnst 0 siblings, 1 reply; 7+ messages in thread From: Zorro Lang @ 2022-08-03 10:40 UTC (permalink / raw) To: liuyd.fnst@fujitsu.com Cc: Zorro Lang, fstests@vger.kernel.org, djwong@kernel.org On Wed, Aug 03, 2022 at 06:48:47AM +0000, liuyd.fnst@fujitsu.com wrote: > Hi Zorro > > On 8/2/22 17:17, Zorro Lang wrote: > > On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: > >> This test require security attr. Skip test if fs doesn't support > >> security attr. E.g. virtiofs > >> > >> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > >> --- > > > > Hmm... looks like we can re-start this discussion long time ago: > > > > https://lore.kernel.org/fstests/20220323023845.saj5en74km7aibdx@zlang-mailbox/ > > > > About how can we deal with those fs doesn't support capabilities, e.g. nfs, virtiofs?? > > Ahh, so I don't need to send a v2 patch until you finish above discussion. Actually I'm not sure if we need a _require_capabilities(), or just use "_require_attrs security" for all filesystems which support/unsupport capabilities. Hope to hear more points. If you'd like to send v2, there's not only g/688 need capabilities. Thanks, Zorro > > > > > Thanks, > > Zorro > > > >> tests/generic/688 | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/tests/generic/688 b/tests/generic/688 > >> index 426286b6..d11b4c21 100755 > >> --- a/tests/generic/688 > >> +++ b/tests/generic/688 > >> @@ -7,6 +7,7 @@ > >> # Functional test for dropping capability bits as part of an fallocate. > >> # > >> . ./common/preamble > >> +. ./common/attr > >> _begin_fstest auto prealloc quick > >> > >> # Override the default cleanup function. > >> @@ -28,6 +29,7 @@ _require_command "$GETCAP_PROG" getcap > >> _require_command "$SETCAP_PROG" setcap > >> _require_xfs_io_command falloc > >> _require_test > >> +_require_attrs security > >> _require_congruent_file_oplen $TEST_DIR 65536 > >> > >> junk_dir=$TEST_DIR/$seq > >> -- > >> 2.34.1 > >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] generic/688: Skip test if fs doesn't support security 2022-08-03 10:40 ` Zorro Lang @ 2022-08-04 1:32 ` liuyd.fnst 0 siblings, 0 replies; 7+ messages in thread From: liuyd.fnst @ 2022-08-04 1:32 UTC (permalink / raw) To: Zorro Lang; +Cc: Zorro Lang, fstests@vger.kernel.org, djwong@kernel.org On 8/3/22 18:40, Zorro Lang wrote: > On Wed, Aug 03, 2022 at 06:48:47AM +0000, liuyd.fnst@fujitsu.com wrote: >> Hi Zorro >> >> On 8/2/22 17:17, Zorro Lang wrote: >>> On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: >>>> This test require security attr. Skip test if fs doesn't support >>>> security attr. E.g. virtiofs >>>> >>>> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> >>>> --- >>> >>> Hmm... looks like we can re-start this discussion long time ago: >>> >>> https://lore.kernel.org/fstests/20220323023845.saj5en74km7aibdx@zlang-mailbox/ >>> >>> About how can we deal with those fs doesn't support capabilities, e.g. nfs, virtiofs?? >> >> Ahh, so I don't need to send a v2 patch until you finish above discussion. > > Actually I'm not sure if we need a _require_capabilities(), or just use > "_require_attrs security" for all filesystems which support/unsupport > capabilities. Hope to hear more points. > I think a _require_capabilities() is much better than "_require_attrs security()". > If you'd like to send v2, there's not only g/688 need capabilities. > > Thanks, > Zorro > >> >>> >>> Thanks, >>> Zorro >>> >>>> tests/generic/688 | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/tests/generic/688 b/tests/generic/688 >>>> index 426286b6..d11b4c21 100755 >>>> --- a/tests/generic/688 >>>> +++ b/tests/generic/688 >>>> @@ -7,6 +7,7 @@ >>>> # Functional test for dropping capability bits as part of an fallocate. >>>> # >>>> . ./common/preamble >>>> +. ./common/attr >>>> _begin_fstest auto prealloc quick >>>> >>>> # Override the default cleanup function. >>>> @@ -28,6 +29,7 @@ _require_command "$GETCAP_PROG" getcap >>>> _require_command "$SETCAP_PROG" setcap >>>> _require_xfs_io_command falloc >>>> _require_test >>>> +_require_attrs security >>>> _require_congruent_file_oplen $TEST_DIR 65536 >>>> >>>> junk_dir=$TEST_DIR/$seq >>>> -- >>>> 2.34.1 >>>> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] generic/688: Skip test if fs doesn't support security 2022-08-02 7:52 [PATCH] generic/688: Skip test if fs doesn't support security Liu Yiding 2022-08-02 9:17 ` Zorro Lang @ 2022-08-02 22:05 ` Dave Chinner 2022-08-03 6:45 ` liuyd.fnst 1 sibling, 1 reply; 7+ messages in thread From: Dave Chinner @ 2022-08-02 22:05 UTC (permalink / raw) To: Liu Yiding; +Cc: fstests On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: > This test require security attr. Skip test if fs doesn't support > security attr. E.g. virtiofs > > Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> > --- > tests/generic/688 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/generic/688 b/tests/generic/688 > index 426286b6..d11b4c21 100755 > --- a/tests/generic/688 > +++ b/tests/generic/688 > @@ -7,6 +7,7 @@ > # Functional test for dropping capability bits as part of an fallocate. > # > . ./common/preamble > +. ./common/attr > _begin_fstest auto prealloc quick Includes don't belong in the test preamble/setup section. They belong a few lines below in the section titled: # Include common functions. Cheers, Dave. -- Dave Chinner david@fromorbit.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] generic/688: Skip test if fs doesn't support security 2022-08-02 22:05 ` Dave Chinner @ 2022-08-03 6:45 ` liuyd.fnst 0 siblings, 0 replies; 7+ messages in thread From: liuyd.fnst @ 2022-08-03 6:45 UTC (permalink / raw) To: Dave Chinner; +Cc: fstests@vger.kernel.org Hi Dave. On 8/3/22 06:05, Dave Chinner wrote: > On Tue, Aug 02, 2022 at 07:52:40AM +0000, Liu Yiding wrote: >> This test require security attr. Skip test if fs doesn't support >> security attr. E.g. virtiofs >> >> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com> >> --- >> tests/generic/688 | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/generic/688 b/tests/generic/688 >> index 426286b6..d11b4c21 100755 >> --- a/tests/generic/688 >> +++ b/tests/generic/688 >> @@ -7,6 +7,7 @@ >> # Functional test for dropping capability bits as part of an fallocate. >> # >> . ./common/preamble >> +. ./common/attr >> _begin_fstest auto prealloc quick > > Includes don't belong in the test preamble/setup section. They > belong a few lines below in the section titled: Thank you for your point. :) > > # Include common functions. > > Cheers, > > Dave. > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-08-04 1:33 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-08-02 7:52 [PATCH] generic/688: Skip test if fs doesn't support security Liu Yiding 2022-08-02 9:17 ` Zorro Lang 2022-08-03 6:48 ` liuyd.fnst 2022-08-03 10:40 ` Zorro Lang 2022-08-04 1:32 ` liuyd.fnst 2022-08-02 22:05 ` Dave Chinner 2022-08-03 6:45 ` liuyd.fnst
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox