From: Amir Goldstein <amir73il@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Leah Rumancik <leah.rumancik@gmail.com>, fstests@vger.kernel.org
Subject: [PATCH] gce-xfstests: fix setup iam policy binding
Date: Thu, 18 Aug 2022 10:15:23 +0300 [thread overview]
Message-ID: <20220818071523.928417-1-amir73il@gmail.com> (raw)
On a new account setup. gce-xfstests setup failed with error:
"Failed to add iam policy binding for roles/..."
On the second (verbose) retry, the opertaion succeeds,
but the script still aborts.
Fix a typo in the first invocation of the command.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
run-fstests/util/gce-do-setup | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/run-fstests/util/gce-do-setup b/run-fstests/util/gce-do-setup
index c06a1e9..037068e 100755
--- a/run-fstests/util/gce-do-setup
+++ b/run-fstests/util/gce-do-setup
@@ -141,9 +141,9 @@ function SetupServiceAccount () {
--display-name "$name"
if ! run_gcloud projects add-iam-policy-binding "$GCE_PROJECT" \
--member "serviceAccount:$srv_acct" \
- --role "projects/$GCE_PROJECT/roles/$role" \
+ --role "$role" \
--verbosity none >& /dev/null ; then
- echo "Failed to add iam policy binding for roles/$role"
+ echo "Failed to add iam policy binding for role $role"
# Re-run to get error message
run_gcloud projects add-iam-policy-binding "$GCE_PROJECT" \
--member "serviceAccount:$srv_acct" \
--
2.25.1
reply other threads:[~2022-08-18 7:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818071523.928417-1-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=leah.rumancik@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox