FS/XFS testing framework
 help / color / mirror / Atom feed
* [PATCH] gce-xfstests: fix setup iam policy binding
@ 2022-08-18  7:15 Amir Goldstein
  0 siblings, 0 replies; only message in thread
From: Amir Goldstein @ 2022-08-18  7:15 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: Leah Rumancik, fstests

On a new account setup. gce-xfstests setup failed with error:

  "Failed to add iam policy binding for roles/..."

On the second (verbose) retry, the opertaion succeeds,
but the script still aborts.

Fix a typo in the first invocation of the command.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 run-fstests/util/gce-do-setup | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/run-fstests/util/gce-do-setup b/run-fstests/util/gce-do-setup
index c06a1e9..037068e 100755
--- a/run-fstests/util/gce-do-setup
+++ b/run-fstests/util/gce-do-setup
@@ -141,9 +141,9 @@ function SetupServiceAccount () {
 		   --display-name "$name"
 	if ! run_gcloud projects add-iam-policy-binding "$GCE_PROJECT" \
 	     --member "serviceAccount:$srv_acct" \
-	     --role "projects/$GCE_PROJECT/roles/$role" \
+	     --role "$role" \
 	     --verbosity none >& /dev/null ; then
-	    echo "Failed to add iam policy binding for roles/$role"
+	    echo "Failed to add iam policy binding for role $role"
 	    # Re-run to get error message
 	    run_gcloud projects add-iam-policy-binding "$GCE_PROJECT" \
 		       --member "serviceAccount:$srv_acct" \
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-18  7:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-18  7:15 [PATCH] gce-xfstests: fix setup iam policy binding Amir Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox