FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: David Disseldorp <ddiss@suse.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] seek_sanity_test: drop unused pagesz
Date: Tue, 11 Oct 2022 23:02:11 +0800	[thread overview]
Message-ID: <20221011150211.ppl34tfylauind54@zlang-mailbox> (raw)
In-Reply-To: <20221011092340.24857-3-ddiss@suse.de>

On Tue, Oct 11, 2022 at 11:23:40AM +0200, David Disseldorp wrote:
> b91889d7 ("seek_sanity_test: use XFS ioctls to determine file allocation
> unit size") left this unused, resulting in:
> 
> seek_sanity_test.c: In function 'get_io_sizes':
> seek_sanity_test.c:70:6: warning: unused variable 'pagesz'
>   int pagesz = sysconf(_SC_PAGE_SIZE);
>       ^~~~~~
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---

OK, finally we can't stand this warning :)

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  src/seek_sanity_test.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 78f835e8..8a586f74 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -67,7 +67,6 @@ static int get_io_sizes(int fd)
>  	off_t pos = 0, offset = 1;
>  	struct stat buf;
>  	int shift, ret;
> -	int pagesz = sysconf(_SC_PAGE_SIZE);
>  
>  	ret = detect_xfs_alloc_unit(fd);
>  	if (!ret)
> -- 
> 2.35.3
> 


      reply	other threads:[~2022-10-11 15:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  9:23 [PATCH 0/2]: minor compiler warning and lsqa fixes David Disseldorp
2022-10-11  9:23 ` [PATCH 1/2] lsqa.pl: fix --header output David Disseldorp
2022-10-11 15:04   ` Zorro Lang
2022-10-11  9:23 ` [PATCH 2/2] seek_sanity_test: drop unused pagesz David Disseldorp
2022-10-11 15:02   ` Zorro Lang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011150211.ppl34tfylauind54@zlang-mailbox \
    --to=zlang@redhat.com \
    --cc=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox