FS/XFS testing framework
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: David Disseldorp <ddiss@suse.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] lsqa.pl: fix --header output
Date: Tue, 11 Oct 2022 23:04:47 +0800	[thread overview]
Message-ID: <20221011150447.hafluwfduvwobkxd@zlang-mailbox> (raw)
In-Reply-To: <20221011092340.24857-2-ddiss@suse.de>

On Tue, Oct 11, 2022 at 11:23:39AM +0200, David Disseldorp wrote:
> 7e98d41a ("fstests: move test group info to test files") replaces the
> post-header "seq" assignment with "./common/preamble\n_begin_fstest ..."
> Update lsqa.pl to recognise the "./common/preamble" line as a header
> divider.
> 
> Signed-off-by: David Disseldorp <ddiss@suse.de>
> ---
>  lsqa.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lsqa.pl b/lsqa.pl
> index 8ca1167f..63bee582 100755
> --- a/lsqa.pl
> +++ b/lsqa.pl
> @@ -99,7 +99,7 @@ sub get_qa_header($) {
>  	m/^# SPDX/i		and next; # SPDX tags
>  	m/^# Copyright/i	and next; # Copyright tags
>  	m/^#\s*\-{10}/		and last; # dashed lines
> -	m/^seq/i		and last; # test start
> +	m/^\. \.\/common\/preamble/ and last; # test start

I think that makes sense, I don't have better idea, so ..

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  
>  	s/^# *//;
>  
> -- 
> 2.35.3
> 


  reply	other threads:[~2022-10-11 15:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  9:23 [PATCH 0/2]: minor compiler warning and lsqa fixes David Disseldorp
2022-10-11  9:23 ` [PATCH 1/2] lsqa.pl: fix --header output David Disseldorp
2022-10-11 15:04   ` Zorro Lang [this message]
2022-10-11  9:23 ` [PATCH 2/2] seek_sanity_test: drop unused pagesz David Disseldorp
2022-10-11 15:02   ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221011150447.hafluwfduvwobkxd@zlang-mailbox \
    --to=zlang@redhat.com \
    --cc=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox