public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Eric Whitney <enwlinux@gmail.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	"Darrick J . Wong" <djwong@kernel.org>
Subject: [PATCH] generic: add missing $FSX_AVOID to fsx invocations
Date: Sat,  5 Nov 2022 14:29:18 -0400	[thread overview]
Message-ID: <20221105182918.24099-1-tytso@mit.edu> (raw)

From: Eric Whitney <enwlinux@gmail.com>

generic/455 fails when run on an ext4 bigalloc file system.  Its
fsx invocations can make insert range and collapse range calls whose
arguments are not cluster aligned, and ext4 will fail those calls for
bigalloc.  They can be suppressed by adding the FSX_AVOID environment
variable to the fsx invocation and setting its value appropriately in
the test environment, as is done for other fsx-based tests.  This
avoids the need to exclude the test to avoid failures and makes it
possible to take advantage of the remainder of its coverage.

[ Also fix generic/457, as requested by Dave Chinner -- TYT]

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---

This is a respin of "generic/455: add $FSX_AVOID" which Eric posted here:
https://lore.kernel.org/r/20221021211950.510006-1-enwlinux@gmail.com
it adds a similar fix for generic/457, as requested by Dave and Zorro.

 tests/generic/455 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/455 b/tests/generic/455
index 649b54108..c13d872c6 100755
--- a/tests/generic/455
+++ b/tests/generic/455
@@ -77,7 +77,7 @@ FSX_OPTS="-N $NUM_OPS -d -P $SANITY_DIR -i $LOGWRITES_DMDEV"
 seeds=(0 0 0 0)
 # Run fsx for a while
 for j in `seq 0 $((NUM_FILES-1))`; do
-	run_check $here/ltp/fsx $FSX_OPTS -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
+	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S ${seeds[$j]} -j $j $SCRATCH_MNT/testfile$j &
 done
 wait
 
-- 
2.31.0


             reply	other threads:[~2022-11-05 18:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 18:29 Theodore Ts'o [this message]
2022-11-06 12:10 ` [PATCH] generic: add missing $FSX_AVOID to fsx invocations Zorro Lang
2022-11-06 21:44   ` Theodore Ts'o
2022-11-07  2:02     ` Zorro Lang
2022-11-07 16:35       ` Theodore Ts'o
2022-11-07 20:09         ` Darrick J. Wong
2022-11-08  2:44           ` Zorro Lang
2022-11-08 15:08             ` Theodore Ts'o
2022-11-08 15:56               ` Zorro Lang
2022-11-08 16:45                 ` Darrick J. Wong
2022-11-11  2:25                   ` Zorro Lang
2023-02-07 18:26         ` Zorro Lang
2023-07-28 20:30           ` Theodore Ts'o
2023-08-01  8:27             ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221105182918.24099-1-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=djwong@kernel.org \
    --cc=enwlinux@gmail.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox