public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, Eric Whitney <enwlinux@gmail.com>,
	"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH] generic: add missing $FSX_AVOID to fsx invocations
Date: Sun, 6 Nov 2022 16:44:05 -0500	[thread overview]
Message-ID: <Y2gqpYhf5n8Y43eZ@mit.edu> (raw)
In-Reply-To: <20221106121031.ywrlqu6w54kgnn2i@zlang-mailbox>

On Sun, Nov 06, 2022 at 08:10:31PM +0800, Zorro Lang wrote:
> 
> Thanks Ted, actually I'm going to merge this patch (with g/457 fix by myself)
> this week.
> 
> But looks like you missed the change on g/457 (might forgot to commit). Anyway,
> I think it's not worth wasting one more week for this small change, I'll help
> to change g/457 when I merge this patch.

Argh, yeah, sorry, I forgot to do the "git add -u".  Anyway, here's
the leftover change that was in my git working directory, if it saves
you 5 seconds or so.  :-)

BTW, I noticed there were a number of fsx --replay-ops invocations
where we could potentially add the $FSX_AVOID.  OTOH, it would
probably make those tests completely pointless, so it might be easier
just for the test runners to relay on a group-based exclusion in those
cases.   What do you think?

				- Ted

diff --git a/tests/generic/457 b/tests/generic/457
index da75798f1..ca0f5e622 100755
--- a/tests/generic/457
+++ b/tests/generic/457
@@ -83,7 +83,7 @@ FSX_OPTS="-N $NUM_OPS -d -k -P $SANITY_DIR -i $LOGWRITES_DMDEV"
 for j in `seq 0 $((NUM_FILES-1))`; do
 	# clone the clone from prev iteration which may have already mutated
 	_cp_reflink $SCRATCH_MNT/testfile$((j-1)) $SCRATCH_MNT/testfile$j
-	run_check $here/ltp/fsx $FSX_OPTS -S 0 -j $j $SCRATCH_MNT/testfile$j &
+	run_check $here/ltp/fsx $FSX_OPTS $FSX_AVOID -S 0 -j $j $SCRATCH_MNT/testfile$j &
 done
 wait
 

  reply	other threads:[~2022-11-06 21:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 18:29 [PATCH] generic: add missing $FSX_AVOID to fsx invocations Theodore Ts'o
2022-11-06 12:10 ` Zorro Lang
2022-11-06 21:44   ` Theodore Ts'o [this message]
2022-11-07  2:02     ` Zorro Lang
2022-11-07 16:35       ` Theodore Ts'o
2022-11-07 20:09         ` Darrick J. Wong
2022-11-08  2:44           ` Zorro Lang
2022-11-08 15:08             ` Theodore Ts'o
2022-11-08 15:56               ` Zorro Lang
2022-11-08 16:45                 ` Darrick J. Wong
2022-11-11  2:25                   ` Zorro Lang
2023-02-07 18:26         ` Zorro Lang
2023-07-28 20:30           ` Theodore Ts'o
2023-08-01  8:27             ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2gqpYhf5n8Y43eZ@mit.edu \
    --to=tytso@mit.edu \
    --cc=djwong@kernel.org \
    --cc=enwlinux@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox