From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: David Disseldorp <ddiss@suse.de>
Subject: [PATCH 1/3] common/attr: require xfs_spaceman for xfs acl_get_max
Date: Tue, 13 Dec 2022 00:08:18 +0100 [thread overview]
Message-ID: <20221212230820.3466-1-ddiss@suse.de> (raw)
For xfs, _acl_get_max() calls xfs_info which in turn calls
"xfs_spaceman -c info ...".
Without this change, xfs_spaceman absence results in:
--- tests/generic/026.out
+++ /home/david/xfstests/results//generic/026.out.bad
@@ -1,9 +1,11 @@
QA output created by 026
+/usr/sbin/xfs_info: line 44: xfs_spaceman: command not found
=== Test out large ACLs ===
+/usr/sbin/xfs_info: line 44: xfs_spaceman: command not found
1 below acl max
acl max
...
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
common/attr | 3 +++
1 file changed, 3 insertions(+)
diff --git a/common/attr b/common/attr
index cce4d1b2..a94c5e4b 100644
--- a/common/attr
+++ b/common/attr
@@ -57,6 +57,9 @@ _acl_get_max()
_require_acl_get_max()
{
+ # _acl_get_max -> xfs_info -> xfs_spaceman
+ [ "$FSTYP" == "xfs" ] && _require_xfs_spaceman_command "info"
+
if [ $(_acl_get_max) -eq 0 ]; then
_notrun "$FSTYP does not define maximum ACL count"
fi
--
2.35.3
next reply other threads:[~2022-12-12 23:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 23:08 David Disseldorp [this message]
2022-12-12 23:08 ` [PATCH 2/3] tests/generic/027: use c-style for loops David Disseldorp
2022-12-13 5:51 ` Eric Biggers
2022-12-13 8:56 ` David Disseldorp
2022-12-12 23:08 ` [PATCH 3/3] check: ensure sect_stop is initialized if interrupted David Disseldorp
2022-12-13 14:51 ` Zorro Lang
2022-12-13 14:41 ` [PATCH 1/3] common/attr: require xfs_spaceman for xfs acl_get_max Zorro Lang
2022-12-13 15:32 ` David Disseldorp
2022-12-13 18:25 ` Zorro Lang
2022-12-13 19:08 ` David Disseldorp
2022-12-13 19:27 ` Darrick J. Wong
2022-12-13 19:58 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221212230820.3466-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox