From: David Disseldorp <ddiss@suse.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/3] tests/generic/027: use c-style for loops
Date: Tue, 13 Dec 2022 09:56:39 +0100 [thread overview]
Message-ID: <20221213095639.4e98895d@echidna.fritz.box> (raw)
In-Reply-To: <Y5gSzdGm2et5E1r+@sol.localdomain>
On Mon, 12 Dec 2022 21:51:09 -0800, Eric Biggers wrote:
> > -while [ $i -le $loop ]; do
> > +for ((i = 1; i < loop; i++)); do
>
> This does one fewer iteration than before.
Gah you're right. I'll drop this patch as it was only intended as a
readability clean-up. Thanks for the review.
Cheers, David
next prev parent reply other threads:[~2022-12-13 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 23:08 [PATCH 1/3] common/attr: require xfs_spaceman for xfs acl_get_max David Disseldorp
2022-12-12 23:08 ` [PATCH 2/3] tests/generic/027: use c-style for loops David Disseldorp
2022-12-13 5:51 ` Eric Biggers
2022-12-13 8:56 ` David Disseldorp [this message]
2022-12-12 23:08 ` [PATCH 3/3] check: ensure sect_stop is initialized if interrupted David Disseldorp
2022-12-13 14:51 ` Zorro Lang
2022-12-13 14:41 ` [PATCH 1/3] common/attr: require xfs_spaceman for xfs acl_get_max Zorro Lang
2022-12-13 15:32 ` David Disseldorp
2022-12-13 18:25 ` Zorro Lang
2022-12-13 19:08 ` David Disseldorp
2022-12-13 19:27 ` Darrick J. Wong
2022-12-13 19:58 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213095639.4e98895d@echidna.fritz.box \
--to=ddiss@suse.de \
--cc=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox