From: David Disseldorp <ddiss@suse.de>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] check: call _check_dmesg even if the test case failed
Date: Wed, 14 Dec 2022 12:33:16 +0100 [thread overview]
Message-ID: <20221214123316.4c26cc69@echidna.fritz.box> (raw)
In-Reply-To: <e8b3ba5973d9b24f33cbdbf99dc894f0ca656e02.1670976506.git.wqu@suse.com>
Hi Qu,
On Wed, 14 Dec 2022 08:08:31 +0800, Qu Wenruo wrote:
...
> index d2e5129620bd..487da43537ad 100755
> --- a/check
> +++ b/check
> @@ -950,6 +950,9 @@ function run_section()
> _scratch_unmount 2> /dev/null
> rm -f ${RESULT_DIR}/require_test*
> rm -f ${RESULT_DIR}/require_scratch*
> + # Even we failed, there may be something interesting in
> + # dmesg which can help debugging.
Nit: "Even though we ...", although the comment is probably unnecessary.
> + _check_dmesg
> tc_status="fail"
> else
> # The test apparently passed, so check for corruption
Makes sense.
Reviewed-by: David Disseldorp <ddiss@suse.de>
prev parent reply other threads:[~2022-12-14 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 0:08 [PATCH] check: call _check_dmesg even if the test case failed Qu Wenruo
2022-12-14 11:33 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221214123316.4c26cc69@echidna.fritz.box \
--to=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox