FS/XFS testing framework
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: Long An <lan@suse.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>
Subject: Re: [PATCH v4] btrfs/011: use $_btrfs_profile_configs to limit the tests
Date: Fri, 20 Jan 2023 18:19:01 +0100	[thread overview]
Message-ID: <20230120181901.5769b7f5@echidna.fritz.box> (raw)
In-Reply-To: <c49028312de0847b1b30328950403ca6a4437fb3.camel@suse.com>

Hi,

On Fri, 20 Jan 2023 15:59:02 +0000, Long An wrote:

...
> > > +               "-m dup -d dup -M:1 no 64" \  
> > 
> > This dup/dup case no longer gets run with a default
> > _btrfs_profile_configs[]. Is that intentional?
> > 
> > Cheers, David  
> 
> I thought profiles from "BTRFS_PROFILE_CONFIGS" should be fine. But
> this really changed behavior with default configs, and will get worse
> if use "_btrfs_profile_configs replace".
> 
> In a brief, I just need a way to limit tests. If the default
> config is not 
> suitable, how about using a new argument to
> "_btrfs_get_profile_configs"?

Yes, a new parameter for _btrfs_get_profile_configs() which adds the
missing "dup:dup" entry sounds reasonable.

Cheers, David

  reply	other threads:[~2023-01-20 17:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 17:22 [PATCH] btrfs/011: use $_btrfs_profile_configs to limit the tests An Long
2023-01-11 12:18 ` David Disseldorp
2023-01-13 16:35   ` [PATCH v2] " An Long
2023-01-13 18:40     ` Zorro Lang
2023-01-14  3:12   ` [PATCH v3] " An Long
2023-01-14  3:19   ` [PATCH v4] " An Long
2023-01-20 11:49     ` David Disseldorp
2023-01-20 15:59       ` Long An
2023-01-20 17:19         ` David Disseldorp [this message]
2023-02-14 15:30   ` [PATCH v5] " An Long
2023-02-14 21:07     ` David Disseldorp
2023-02-15  5:12       ` Long An
2023-02-15  5:13   ` [PATCH v6] " An Long
2023-02-16 14:55     ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230120181901.5769b7f5@echidna.fritz.box \
    --to=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    --cc=lan@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox