FS/XFS testing framework
 help / color / mirror / Atom feed
From: cem@kernel.org
To: fstests@vger.kernel.org
Subject: [PATCH] xfstests: Enable _test_mkfs to force a mkfs on a xfs filesystem
Date: Wed, 24 May 2023 15:42:07 +0200	[thread overview]
Message-ID: <20230524134207.38224-1-cem@kernel.org> (raw)

From: Carlos Maiolino <cmaiolino@redhat.com>

Calling _test_mkfs on an already initialized xfs FS will fail as the
initialization is not enforced by '-f' argument, unless it's included in
MKFS_OPTIONS.
So, adding 'RECREATE_TEST_DEV=true' to the config file end up being useless
for xfs filesystems.

So, adding the a specific xfs optiong in _test_mkfs using -f argument
makes RECREATE_TEST_DEV actually useful.

Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 common/rc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/rc b/common/rc
index 37074371..dd5d7bc1 100644
--- a/common/rc
+++ b/common/rc
@@ -605,6 +605,9 @@ _test_mkfs()
     ext2|ext3|ext4)
 	$MKFS_PROG -t $FSTYP -- -F $MKFS_OPTIONS $* $TEST_DEV
 	;;
+    xfs)
+	$MKFS_PROG -t $FSTYP -- -f $MKFS_OPTIONS $* $TEST_DEV
+	;;
     *)
 	yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $TEST_DEV
 	;;
-- 
2.30.2


             reply	other threads:[~2023-05-24 13:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 13:42 cem [this message]
2023-05-24 15:16 ` [PATCH] xfstests: Enable _test_mkfs to force a mkfs on a xfs filesystem Darrick J. Wong
2023-05-25  4:36   ` Zorro Lang
2023-05-25 19:13     ` Darrick J. Wong
2023-05-26 19:52       ` Zorro Lang
2023-05-29  7:58         ` Carlos Maiolino
2023-06-02  1:15           ` Darrick J. Wong
2023-06-02 10:44             ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524134207.38224-1-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox