Re: [PATCH] xfstests: Enable _test_mkfs to force a mkfs on a xfs filesystem

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, May 24, 2023 at 03:42:07PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cmaiolino@redhat.com>
> 
> Calling _test_mkfs on an already initialized xfs FS will fail as the
> initialization is not enforced by '-f' argument, unless it's included in
> MKFS_OPTIONS.
> So, adding 'RECREATE_TEST_DEV=true' to the config file end up being useless
> for xfs filesystems.
> 
> So, adding the a specific xfs optiong in _test_mkfs using -f argument
> makes RECREATE_TEST_DEV actually useful.
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>

Makese sense to me,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  common/rc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index 37074371..dd5d7bc1 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -605,6 +605,9 @@ _test_mkfs()
>      ext2|ext3|ext4)
>  	$MKFS_PROG -t $FSTYP -- -F $MKFS_OPTIONS $* $TEST_DEV
>  	;;
> +    xfs)
> +	$MKFS_PROG -t $FSTYP -- -f $MKFS_OPTIONS $* $TEST_DEV
> +	;;
>      *)
>  	yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $TEST_DEV
>  	;;
> -- 
> 2.30.2
>