* [PATCH] Skip weird open dir tests
@ 2023-05-24 18:27 Amir Goldstein
2023-05-25 7:04 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Amir Goldstein @ 2023-05-24 18:27 UTC (permalink / raw)
To: linux-unionfs; +Cc: fstests, Christian Brauner, Miklos Szeredi
After kernel commit 43b450632676 ("open: return EINVAL for O_DIRECTORY
| O_CREAT") the results of this test depends on the tested kernel
version.
This is not an overlayfs specific test, so skip it.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
For whoever is testing overlayfs with fstests/unionmount,
unionmount broke in kernel v6.4-rc.
I pushed this patch to unionmount master branch.
Please update your test setups.
Thanks,
Amir.
run | 1 -
1 file changed, 1 deletion(-)
diff --git a/run b/run
index bda6177..3a6efc3 100755
--- a/run
+++ b/run
@@ -256,7 +256,6 @@ tests = [
"dir-open",
"dir-weird-open",
"dir-open-dir",
- "dir-weird-open-dir",
"dir-sym1-open",
"dir-sym1-weird-open",
"dir-sym2-open",
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Skip weird open dir tests
2023-05-24 18:27 [PATCH] Skip weird open dir tests Amir Goldstein
@ 2023-05-25 7:04 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2023-05-25 7:04 UTC (permalink / raw)
To: Amir Goldstein; +Cc: linux-unionfs, fstests, Miklos Szeredi
On Wed, May 24, 2023 at 09:27:36PM +0300, Amir Goldstein wrote:
> After kernel commit 43b450632676 ("open: return EINVAL for O_DIRECTORY
> | O_CREAT") the results of this test depends on the tested kernel
> version.
>
> This is not an overlayfs specific test, so skip it.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
Thanks for fixing this,
Acked-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-25 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-24 18:27 [PATCH] Skip weird open dir tests Amir Goldstein
2023-05-25 7:04 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox