From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>, "Darrick J. Wong" <djwong@kernel.org>
Subject: [PATCH 2/2] report: remove xmlns specifier
Date: Thu, 6 Jul 2023 16:42:32 -0400 [thread overview]
Message-ID: <20230706204232.1577765-2-tytso@mit.edu> (raw)
In-Reply-To: <20230706204232.1577765-1-tytso@mit.edu>
By specifying "xmlns=https://git.kernel.org/.../xfstests-dev.git",
this causes XML complaint parsers, such as used by the python
junitparser library, to put all of the XML elements into a namespace,
which then causes junitparser to toss its cookies.
This can be worked-around in a test runner script via:
sed -i.orig -e 's/xmlns=\".*\"//' "$RESULT_BASE/result.xml"
but it's better not to include the xmlns line at all in the first
place, since this may cause other users of fstests who are using
the Python junitparser library a lot of headaches.
Cc: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
common/report | 1 -
1 file changed, 1 deletion(-)
diff --git a/common/report b/common/report
index 3ad14f94e..081df988f 100644
--- a/common/report
+++ b/common/report
@@ -127,7 +127,6 @@ _xunit_make_section_report()
local fstests_ns="https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git"
cat >> "$tmp_fn" << ENDL
<testsuite
- xmlns="$fstests_ns"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="$fstests_ns $fstests_ns/tree/doc/xunit.xsd"
--
2.31.0
next prev parent reply other threads:[~2023-07-06 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 20:42 [PATCH 1/2] report: safely update the result.xml file Theodore Ts'o
2023-07-06 20:42 ` Theodore Ts'o [this message]
2023-07-07 14:55 ` [PATCH 2/2] report: remove xmlns specifier Darrick J. Wong
2023-07-07 15:01 ` [PATCH 1/2] report: safely update the result.xml file Darrick J. Wong
2023-07-07 16:17 ` Zorro Lang
2023-07-07 19:13 ` Theodore Ts'o
2023-07-08 3:02 ` Zorro Lang
2023-07-08 4:31 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706204232.1577765-2-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox