From: "Theodore Ts'o" <tytso@mit.edu>
To: Zorro Lang <zlang@redhat.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] report: safely update the result.xml file
Date: Sat, 8 Jul 2023 00:31:20 -0400 [thread overview]
Message-ID: <20230708043120.GN1178919@mit.edu> (raw)
In-Reply-To: <20230708030205.zjavir3xuu7axgaw@zlang-mailbox>
On Sat, Jul 08, 2023 at 11:02:05AM +0800, Zorro Lang wrote:
>
> Thanks Ted, good to know that! Maybe we can have a "_mv" in common/rc does
> "sync $1 && mv $1 $2".
Perhaps, although I can't think of any other place in xfstests were we
are actively (and repeatedly) renaming one file on top of another one,
or rewriting a file in place.
There are certainly places where we use "sed -i" to rewrite a file in
place, and it does do write the file to a new file, and then renames
it to the original file's name (yay!), although it doesn't do an fsync
before the rename (boo!). That's arguably a bug report we should send
to the maintainer of the sed package.
- Ted
prev parent reply other threads:[~2023-07-08 4:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 20:42 [PATCH 1/2] report: safely update the result.xml file Theodore Ts'o
2023-07-06 20:42 ` [PATCH 2/2] report: remove xmlns specifier Theodore Ts'o
2023-07-07 14:55 ` Darrick J. Wong
2023-07-07 15:01 ` [PATCH 1/2] report: safely update the result.xml file Darrick J. Wong
2023-07-07 16:17 ` Zorro Lang
2023-07-07 19:13 ` Theodore Ts'o
2023-07-08 3:02 ` Zorro Lang
2023-07-08 4:31 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230708043120.GN1178919@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox