FS/XFS testing framework
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: fstests@vger.kernel.org
Cc: David Disseldorp <ddiss@suse.de>
Subject: [PATCH v2] common/rc: drop 'fsck -f' parameter from _repair_test_fs
Date: Wed, 16 Aug 2023 12:33:30 +0200	[thread overview]
Message-ID: <20230816103330.961-1-ddiss@suse.de> (raw)

The '-f' parameter is fsck.ext# specific, where it's documented to:
  Force checking even if filesystem is marked clean

_repair_test_fs() is only called on _check_test_fs() failure, so
dropping the parameter should be possible without changing ext#
behaviour.
Doing so fixes _repair_test_fs() on exfat, where fsck.exfat doesn't
support '-f'.

Signed-off-by: David Disseldorp <ddiss@suse.de>
---
v2: drop -f from default case instead of splitting out exfat case

 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index 5c4429ed..66d270ac 100644
--- a/common/rc
+++ b/common/rc
@@ -1231,7 +1231,7 @@ _repair_test_fs()
 		;;
 	*)
 		# Let's hope fsck -y suffices...
-		fsck -t $FSTYP -fy $TEST_DEV >$tmp.repair 2>&1
+		fsck -t $FSTYP -y $TEST_DEV >$tmp.repair 2>&1
 		res=$?
 		if test "$res" -lt 4 ; then
 			res=0
-- 
2.35.3


             reply	other threads:[~2023-08-16 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 10:33 David Disseldorp [this message]
2023-08-16 14:55 ` [PATCH v2] common/rc: drop 'fsck -f' parameter from _repair_test_fs Zorro Lang
2023-08-16 19:42   ` David Disseldorp
2023-08-17  5:59   ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230816103330.961-1-ddiss@suse.de \
    --to=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox