Re: [PATCH v2] common/rc: drop 'fsck -f' parameter from _repair_test_fs

[David Disseldorp <ddiss@suse.de>]

On Wed, 16 Aug 2023 22:55:43 +0800, Zorro Lang wrote:

> On Wed, Aug 16, 2023 at 12:33:30PM +0200, David Disseldorp wrote:
> > The '-f' parameter is fsck.ext# specific, where it's documented to:
> >   Force checking even if filesystem is marked clean
> > 
> > _repair_test_fs() is only called on _check_test_fs() failure, so
> > dropping the parameter should be possible without changing ext#
> > behaviour.
> > Doing so fixes _repair_test_fs() on exfat, where fsck.exfat doesn't
> > support '-f'.
> > 
> > Signed-off-by: David Disseldorp <ddiss@suse.de>
> > ---
> > v2: drop -f from default case instead of splitting out exfat case  
> 
> This version is good to me.
> 
> Reviewed-by: Zorro Lang <zlang@redhat.com>

Thanks.

> I remembered you hope to add a btrfs branch to _repair_scratch_fs and
> _repair_test_fs [1]. Is that still in your plan? Anand, could you provide
> more suggestions about that?

Yes, that's still my plan, but I was hoping to get some more input on
whether "btrfs check --repair ..." is sufficient before proposing the
change.

Cheers, David