* Re: [PATCH] dm: error: Add support for zoned block devices
[not found] <20231023224513.344380-1-dlemoal@kernel.org>
@ 2023-10-24 6:39 ` Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2023-10-24 6:39 UTC (permalink / raw)
To: Damien Le Moal
Cc: dm-devel, Mike Snitzer, Christoph Hellwig, Johannes Thumshirn,
Naohiro Aota, fstests
Thanks, this looks good to me and fixes the problems I've seen
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Christoph Hellwig <hch@lst.de>
FTI, this is the xfstests change we need to use dm-error for zoned
devices in xfstests:
diff --git a/common/rc b/common/rc
index 741579af..9e07d79d 100644
--- a/common/rc
+++ b/common/rc
@@ -2174,12 +2174,10 @@ _require_dm_target()
_notrun "This test requires dm $target support"
fi
- # dm-error cannot handle the zone information
- #
# dm-snapshot and dm-thin-pool cannot ensure sequential writes on
# the backing device
case $target in
- error|snapshot|thin-pool)
+ snapshot|thin-pool)
_require_non_zoned_device ${SCRATCH_DEV}
;;
esac
^ permalink raw reply related [flat|nested] only message in thread