[PATCH v2] xfs/263: Remove mkfs.xfs data section argument

[PATCH v2] xfs/263: Remove mkfs.xfs data section argument

[Yang Xu]

On machine with using raid, this case will trigger
the following error:
==== NO CRC ====
+mkfs.xfs: small data volume, ignoring data volume stripe unit 512 and stripe width 512
== Options: rw ==
== Options: usrquota,rw ==

mkfs.xfs generates this error since xfsprogs commit 42371fb36
("mkfs: ignore data blockdev stripe geometry for small filesystems").
It disables automatic detection of stripe unit and width if the
data device is less than 1GB.

But, since xfstests commit baaa392c("xfs/263: don't hardcode inode numbers in output"),
we don't care the inode number. So let's remove this data section size argument
instead of increasing this size to 1G, then we can solve this false
positive.

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 tests/xfs/263 | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/xfs/263 b/tests/xfs/263
index fadd6280..bce4e13f 100755
--- a/tests/xfs/263
+++ b/tests/xfs/263
@@ -72,12 +72,11 @@ function test_all_state()
 }
 
 echo "==== NO CRC ===="
-# Control size to control inode numbers
-_scratch_mkfs_xfs "-m crc=0 -n ftype=0 -d size=512m" >> $seqres.full
+_scratch_mkfs_xfs "-m crc=0 -n ftype=0" >> $seqres.full
 test_all_state
 
 echo "==== CRC ===="
-_scratch_mkfs_xfs "-m crc=1 -d size=512m" >>$seqres.full
+_scratch_mkfs_xfs "-m crc=1" >>$seqres.full
 test_all_state
 
 status=0
-- 
2.39.1

Re: [PATCH v2] xfs/263: Remove mkfs.xfs data section argument

[Zorro Lang]

On Thu, Nov 16, 2023 at 02:33:15AM -0500, Yang Xu wrote:
> On machine with using raid, this case will trigger
> the following error:
> ==== NO CRC ====
> +mkfs.xfs: small data volume, ignoring data volume stripe unit 512 and stripe width 512
> == Options: rw ==
> == Options: usrquota,rw ==
> 
> mkfs.xfs generates this error since xfsprogs commit 42371fb36
> ("mkfs: ignore data blockdev stripe geometry for small filesystems").
> It disables automatic detection of stripe unit and width if the
> data device is less than 1GB.
> 
> But, since xfstests commit baaa392c("xfs/263: don't hardcode inode numbers in output"),
> we don't care the inode number. So let's remove this data section size argument
> instead of increasing this size to 1G, then we can solve this false
> positive.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---

Good to me,

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/xfs/263 | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/xfs/263 b/tests/xfs/263
> index fadd6280..bce4e13f 100755
> --- a/tests/xfs/263
> +++ b/tests/xfs/263
> @@ -72,12 +72,11 @@ function test_all_state()
>  }
>  
>  echo "==== NO CRC ===="
> -# Control size to control inode numbers
> -_scratch_mkfs_xfs "-m crc=0 -n ftype=0 -d size=512m" >> $seqres.full
> +_scratch_mkfs_xfs "-m crc=0 -n ftype=0" >> $seqres.full
>  test_all_state
>  
>  echo "==== CRC ===="
> -_scratch_mkfs_xfs "-m crc=1 -d size=512m" >>$seqres.full
> +_scratch_mkfs_xfs "-m crc=1" >>$seqres.full
>  test_all_state
>  
>  status=0
> -- 
> 2.39.1
> 
> 

Re: [PATCH v2] xfs/263: Remove mkfs.xfs data section argument

[Bill O'Donnell]

On Thu, Nov 16, 2023 at 02:33:15AM -0500, Yang Xu wrote:
> On machine with using raid, this case will trigger
> the following error:
> ==== NO CRC ====
> +mkfs.xfs: small data volume, ignoring data volume stripe unit 512 and stripe width 512
> == Options: rw ==
> == Options: usrquota,rw ==
> 
> mkfs.xfs generates this error since xfsprogs commit 42371fb36
> ("mkfs: ignore data blockdev stripe geometry for small filesystems").
> It disables automatic detection of stripe unit and width if the
> data device is less than 1GB.
> 
> But, since xfstests commit baaa392c("xfs/263: don't hardcode inode numbers in output"),
> we don't care the inode number. So let's remove this data section size argument
> instead of increasing this size to 1G, then we can solve this false
> positive.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>

Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>


> ---
>  tests/xfs/263 | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/xfs/263 b/tests/xfs/263
> index fadd6280..bce4e13f 100755
> --- a/tests/xfs/263
> +++ b/tests/xfs/263
> @@ -72,12 +72,11 @@ function test_all_state()
>  }
>  
>  echo "==== NO CRC ===="
> -# Control size to control inode numbers
> -_scratch_mkfs_xfs "-m crc=0 -n ftype=0 -d size=512m" >> $seqres.full
> +_scratch_mkfs_xfs "-m crc=0 -n ftype=0" >> $seqres.full
>  test_all_state
>  
>  echo "==== CRC ===="
> -_scratch_mkfs_xfs "-m crc=1 -d size=512m" >>$seqres.full
> +_scratch_mkfs_xfs "-m crc=1" >>$seqres.full
>  test_all_state
>  
>  status=0
> -- 
> 2.39.1
> 
> 

Re: [PATCH v2] xfs/263: Remove mkfs.xfs data section argument

[Darrick J. Wong]

On Thu, Nov 16, 2023 at 02:33:15AM -0500, Yang Xu wrote:
> On machine with using raid, this case will trigger
> the following error:
> ==== NO CRC ====
> +mkfs.xfs: small data volume, ignoring data volume stripe unit 512 and stripe width 512
> == Options: rw ==
> == Options: usrquota,rw ==
> 
> mkfs.xfs generates this error since xfsprogs commit 42371fb36
> ("mkfs: ignore data blockdev stripe geometry for small filesystems").
> It disables automatic detection of stripe unit and width if the
> data device is less than 1GB.
> 
> But, since xfstests commit baaa392c("xfs/263: don't hardcode inode numbers in output"),
> we don't care the inode number. So let's remove this data section size argument
> instead of increasing this size to 1G, then we can solve this false
> positive.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/xfs/263 | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/xfs/263 b/tests/xfs/263
> index fadd6280..bce4e13f 100755
> --- a/tests/xfs/263
> +++ b/tests/xfs/263
> @@ -72,12 +72,11 @@ function test_all_state()
>  }
>  
>  echo "==== NO CRC ===="
> -# Control size to control inode numbers
> -_scratch_mkfs_xfs "-m crc=0 -n ftype=0 -d size=512m" >> $seqres.full
> +_scratch_mkfs_xfs "-m crc=0 -n ftype=0" >> $seqres.full
>  test_all_state
>  
>  echo "==== CRC ===="
> -_scratch_mkfs_xfs "-m crc=1 -d size=512m" >>$seqres.full
> +_scratch_mkfs_xfs "-m crc=1" >>$seqres.full
>  test_all_state
>  
>  status=0
> -- 
> 2.39.1
> 
>