[PATCH] xfs/598: Add missing "fixed_by" hints

[PATCH] xfs/598: Add missing "fixed_by" hints

[Pavel Reichl]

Kernel patches, the very same as for xfs/597, are necessary for scrub
to function as expected.

_check_xfs_filesystem: filesystem on /dev/sda3 failed scrub

xfs_scrub -v -d -n output ***
EXPERIMENTAL xfs_scrub program in use! Use at your own risk!
Phase 1: Find filesystem geometry.
/mnt/scratch: using 2 threads to scrub.
Phase 2: Check internal metadata.
Info: AG 1 superblock: Optimization is possible. (scrub.c line 212)
Info: AG 2 superblock: Optimization is possible. (scrub.c line 212)
Info: AG 3 superblock: Optimization is possible. (scrub.c line 212)
Phase 3: Scan all inodes.
Corruption: inode 131 (0/131) directory entries: Repairs are required. (scrub.c line 196)
Phase 5: Check directory tree.
Info: /mnt/scratch: Filesystem has errors, skipping connectivity checks. (phase5.c line 392)
Phase 7: Check summary counters.
203.0MiB data used;  5 inodes used.
64.2MiB data found; 5 inodes found.
5 inodes counted; 5 inodes checked.
/mnt/scratch: corruptions found: 1
/mnt/scratch: Re-run xfs_scrub without -n.
end xfs_scrub output
mount output ***

Signed-off-by: Pavel Reichl <preichl@redhat.com>
---
 tests/xfs/598 | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/xfs/598 b/tests/xfs/598
index 449bd711..760cd861 100755
--- a/tests/xfs/598
+++ b/tests/xfs/598
@@ -19,6 +19,11 @@ _cleanup()
 _fixed_by_git_commit xfsprogs 10a01bcd \
 	"xfs_db: fix metadump name obfuscation for ascii-ci filesystems"
 
+_fixed_by_kernel_commit a9248538facc \
+        "xfs: stabilize the dirent name transformation function used for ascii-ci dir hash computation"
+_fixed_by_kernel_commit 9dceccc5822f \
+        "xfs: use the directory name hash function for dir scrubbing"
+
 _supported_fs xfs
 _require_test
 _require_scratch
-- 
2.43.0

Re: [PATCH] xfs/598: Add missing "fixed_by" hints

[Bill O'Donnell]

On Wed, Dec 06, 2023 at 08:15:25AM +0100, Pavel Reichl wrote:
> Kernel patches, the very same as for xfs/597, are necessary for scrub
> to function as expected.
> 
> _check_xfs_filesystem: filesystem on /dev/sda3 failed scrub
> 
> xfs_scrub -v -d -n output ***
> EXPERIMENTAL xfs_scrub program in use! Use at your own risk!
> Phase 1: Find filesystem geometry.
> /mnt/scratch: using 2 threads to scrub.
> Phase 2: Check internal metadata.
> Info: AG 1 superblock: Optimization is possible. (scrub.c line 212)
> Info: AG 2 superblock: Optimization is possible. (scrub.c line 212)
> Info: AG 3 superblock: Optimization is possible. (scrub.c line 212)
> Phase 3: Scan all inodes.
> Corruption: inode 131 (0/131) directory entries: Repairs are required. (scrub.c line 196)
> Phase 5: Check directory tree.
> Info: /mnt/scratch: Filesystem has errors, skipping connectivity checks. (phase5.c line 392)
> Phase 7: Check summary counters.
> 203.0MiB data used;  5 inodes used.
> 64.2MiB data found; 5 inodes found.
> 5 inodes counted; 5 inodes checked.
> /mnt/scratch: corruptions found: 1
> /mnt/scratch: Re-run xfs_scrub without -n.
> end xfs_scrub output
> mount output ***
> 
> Signed-off-by: Pavel Reichl <preichl@redhat.com>

Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>

> ---
>  tests/xfs/598 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/xfs/598 b/tests/xfs/598
> index 449bd711..760cd861 100755
> --- a/tests/xfs/598
> +++ b/tests/xfs/598
> @@ -19,6 +19,11 @@ _cleanup()
>  _fixed_by_git_commit xfsprogs 10a01bcd \
>  	"xfs_db: fix metadump name obfuscation for ascii-ci filesystems"
>  
> +_fixed_by_kernel_commit a9248538facc \
> +        "xfs: stabilize the dirent name transformation function used for ascii-ci dir hash computation"
> +_fixed_by_kernel_commit 9dceccc5822f \
> +        "xfs: use the directory name hash function for dir scrubbing"
> +
>  _supported_fs xfs
>  _require_test
>  _require_scratch
> -- 
> 2.43.0
> 
>