From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common/rc: fix unknown _xfs_repair_test_fs function name
Date: Sun, 24 Mar 2024 09:58:42 -0700 [thread overview]
Message-ID: <20240324165842.GA6379@frogsfrogsfrogs> (raw)
In-Reply-To: <20240324141707.303321-1-zlang@kernel.org>
On Sun, Mar 24, 2024 at 10:17:07PM +0800, Zorro Lang wrote:
> Sometimes I hit below errors:
> ./common/rc: line 1293: _xfs_repair_test_fs: command not found
> ./common/rc: line 1298: _xfs_repair_test_fs: command not found
>
> The _repair_test_fs trys to call _xfs_repair_test_fs(), but there's
> not that function in fstests. According to commit c7d81cdecbef,
> it brought in _test_xfs_repair, but called wrong name. So fix it.
>
> Fixes: c7d81cdecbef ("check: try to fix the test device if it gets corrupted")
> Signed-off-by: Zorro Lang <zlang@kernel.org>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> common/rc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 37d26bf2..47736dc3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1290,12 +1290,12 @@ _repair_test_fs()
> res=$?
> if [ $res -gt 0 ]; then
> echo "mount returns $res; zap log?" >>$tmp.repair
> - _xfs_repair_test_fs -L >>$tmp.repair 2>&1
> + _test_xfs_repair -L >>$tmp.repair 2>&1
> echo "log zap returns $?" >> $tmp.repair
> else
> umount "$TEST_DEV"
> fi
> - _xfs_repair_test_fs "$@" >>$tmp.repair 2>&1
> + _test_xfs_repair "$@" >>$tmp.repair 2>&1
> res=$?
> fi
> ;;
> --
> 2.44.0
>
>
prev parent reply other threads:[~2024-03-24 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 14:17 [PATCH] common/rc: fix unknown _xfs_repair_test_fs function name Zorro Lang
2024-03-24 16:58 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240324165842.GA6379@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox