* [PATCH] common/rc: fix unknown _xfs_repair_test_fs function name
@ 2024-03-24 14:17 Zorro Lang
2024-03-24 16:58 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Zorro Lang @ 2024-03-24 14:17 UTC (permalink / raw)
To: fstests
Sometimes I hit below errors:
./common/rc: line 1293: _xfs_repair_test_fs: command not found
./common/rc: line 1298: _xfs_repair_test_fs: command not found
The _repair_test_fs trys to call _xfs_repair_test_fs(), but there's
not that function in fstests. According to commit c7d81cdecbef,
it brought in _test_xfs_repair, but called wrong name. So fix it.
Fixes: c7d81cdecbef ("check: try to fix the test device if it gets corrupted")
Signed-off-by: Zorro Lang <zlang@kernel.org>
---
common/rc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/rc b/common/rc
index 37d26bf2..47736dc3 100644
--- a/common/rc
+++ b/common/rc
@@ -1290,12 +1290,12 @@ _repair_test_fs()
res=$?
if [ $res -gt 0 ]; then
echo "mount returns $res; zap log?" >>$tmp.repair
- _xfs_repair_test_fs -L >>$tmp.repair 2>&1
+ _test_xfs_repair -L >>$tmp.repair 2>&1
echo "log zap returns $?" >> $tmp.repair
else
umount "$TEST_DEV"
fi
- _xfs_repair_test_fs "$@" >>$tmp.repair 2>&1
+ _test_xfs_repair "$@" >>$tmp.repair 2>&1
res=$?
fi
;;
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] common/rc: fix unknown _xfs_repair_test_fs function name
2024-03-24 14:17 [PATCH] common/rc: fix unknown _xfs_repair_test_fs function name Zorro Lang
@ 2024-03-24 16:58 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2024-03-24 16:58 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Sun, Mar 24, 2024 at 10:17:07PM +0800, Zorro Lang wrote:
> Sometimes I hit below errors:
> ./common/rc: line 1293: _xfs_repair_test_fs: command not found
> ./common/rc: line 1298: _xfs_repair_test_fs: command not found
>
> The _repair_test_fs trys to call _xfs_repair_test_fs(), but there's
> not that function in fstests. According to commit c7d81cdecbef,
> it brought in _test_xfs_repair, but called wrong name. So fix it.
>
> Fixes: c7d81cdecbef ("check: try to fix the test device if it gets corrupted")
> Signed-off-by: Zorro Lang <zlang@kernel.org>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> common/rc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/rc b/common/rc
> index 37d26bf2..47736dc3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -1290,12 +1290,12 @@ _repair_test_fs()
> res=$?
> if [ $res -gt 0 ]; then
> echo "mount returns $res; zap log?" >>$tmp.repair
> - _xfs_repair_test_fs -L >>$tmp.repair 2>&1
> + _test_xfs_repair -L >>$tmp.repair 2>&1
> echo "log zap returns $?" >> $tmp.repair
> else
> umount "$TEST_DEV"
> fi
> - _xfs_repair_test_fs "$@" >>$tmp.repair 2>&1
> + _test_xfs_repair "$@" >>$tmp.repair 2>&1
> res=$?
> fi
> ;;
> --
> 2.44.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-24 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-24 14:17 [PATCH] common/rc: fix unknown _xfs_repair_test_fs function name Zorro Lang
2024-03-24 16:58 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox